the add-on generates redirect visit types, hence we need to record that in the database. We should also add "unknown" type to store weird visits if we need to
In fact, there are a ton more types defined in nsINavHIstoryService,idl ( http://mxr.mozilla.org/mozilla-central/source/toolkit/components/places/nsINavHistoryService.idl#1395 ) Things like: - embedded type (for image loading) - frame switching - download links etc... We definitely have to rethink how visit types are stored. At the very list we need a reasonable mechanism which allows for storing visits of various types without changing schema in production. Stefan, Ed and Max need to talk it through
Summary: Visits.type needs two more types: redirect and unknown → Need to extend Visits.type to accommodate for redirect, download, embedded and other transition types
Not using the addon anymore. Not storing data in MySQL anymore.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.