Closed Bug 700498 Opened 8 years ago Closed 8 years ago

Clean up some StringBuffer helper methods

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla10
Tracking Status
firefox9 + fixed

People

(Reporter: Waldo, Assigned: Waldo)

Details

(Whiteboard: [qa-])

Attachments

(1 file)

Attached patch PatchSplinter Review
append doesn't need to take a JSAtom*, it can just take a JSLinearString*.  That lets us not try to linearize strings that are known to be linear but which aren't also atoms.
Attachment #572669 - Flags: review?(cdleary)
Attachment #572669 - Flags: review?(cdleary) → review+
Comment on attachment 572669 [details] [diff] [review]
Patch

I may have a branch patch or two which will build upon these changes, so it would be helpful to me if this were also landed on branches.
Attachment #572669 - Flags: approval-mozilla-beta?
Attachment #572669 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/7ee634818139
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
[Triage Comment]
Since this has been requested for both aurora and beta, and is in a sensitive area of code, would you mind providing a risk assessment? If considered low-risk, we'll try to approve for landing this week.
It's low-risk -- the code's short and easy to understand, and the changes are simple.

Note that this landed before the merge, so it's already in mozilla-aurora, which I guess means this request is only for mozilla-beta.
Attachment #572669 - Flags: approval-mozilla-aurora?
Marking sec-review-needed per email from akeybl
Comment on attachment 572669 [details] [diff] [review]
Patch

[triage comment]
Approved for beta. Please land as soon as possible.
Attachment #572669 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Normally we would QA- code-cleanup bugs, but based on other comments in this bug I am wondering if there is anything special QA needs to verify.
Whiteboard: [qa?]
(In reply to Anthony Hughes, Mozilla QA (irc: ashughes) from comment #10)
> Normally we would QA- code-cleanup bugs, but based on other comments in this
> bug I am wondering if there is anything special QA needs to verify.

[Triage Comment]
Would somebody mind addressing Anthony's question by tomorrow at 12:00PM PT 12/14? We will be holding our FF9 sign-offs later that afternoon, and need to be able to verify. Thanks!
Oops, sorry, missed this at the time.

I'd say probably not.  The patch is small enough that simply by observation it's fine.  And the compiler may end up being smart enough to see through the changes here and make things work most optimally anyway, depending.  So take your time with trickier changes than this, I think.
QA- based on comment 12.
Whiteboard: [qa?] → [qa-]
You need to log in before you can comment on or make changes to this bug.