Closed
Bug 700517
Opened 13 years ago
Closed 12 years ago
Add "ret imm16" instruction for x86 and x86-64.
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla11
People
(Reporter: nbp, Assigned: nbp)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
2.06 KB,
patch
|
dvander
:
review+
emorley
:
checkin+
|
Details | Diff | Splinter Review |
1.13 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
IonMonkey has wrapper functions around C/C++ function calls. Arguments are pushed to these wrappers and the wrappers are in charge of getting rid of the space reserved for the arguments, to reduce the space consumed inside the Jitted code. Currently, a hack is done to unwind the arguments and copy the return address at the top level. The "ret imm16" handle such case and we should use it to unwind list of arguments known at compile time.
Assignee | ||
Updated•13 years ago
|
Assignee: general → nicolas.b.pierron
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #572696 -
Flags: review?(dvander)
Updated•13 years ago
|
Attachment #572696 -
Flags: review?(dvander) → review+
Assignee | ||
Comment 2•13 years ago
|
||
Attachment #572698 -
Flags: review?(dvander)
Comment on attachment 572698 [details] [diff] [review] IM patch, Add retn. Review of attachment 572698 [details] [diff] [review]: ----------------------------------------------------------------- Prefer if this was named "retn" instead to match Intel syntax, but this is not a strong preference.
Attachment #572698 -
Flags: review?(dvander) → review+
Assignee | ||
Updated•13 years ago
|
Attachment #572696 -
Flags: checkin?(dvander)
Comment 4•12 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=73b8ab2861e1 Will push tomorrow presuming green :-)
Comment 5•12 years ago
|
||
Comment on attachment 572696 [details] [diff] [review] MC patch, Add retn. https://hg.mozilla.org/mozilla-central/rev/e3eaae25901c
Attachment #572696 -
Flags: checkin?(dvander) → checkin+
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in
before you can comment on or make changes to this bug.
Description
•