Closed Bug 700534 Opened 13 years ago Closed 13 years ago

make local buildbot-config modification on test-master01 permanent

Categories

(Release Engineering :: General, defect, P3)

x86
Linux
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: nthomas, Assigned: bear)

Details

(Whiteboard: [buildmasters])

Attachments

(1 file)

Namely:
diff -r 31feb5db6a19 mozilla-tests/tests_master.cfg
--- a/mozilla-tests/tests_master.cfg	Mon Nov 07 12:32:14 2011 -0500
+++ b/mozilla-tests/tests_master.cfg	Mon Nov 07 18:00:29 2011 -0800
@@ -92,6 +92,7 @@
 c['change_source'].append(PBChangeSource())
 
 import passwords
+reload(passwords)
 from passwords import BBDB_URL
 c['db_url'] = BBDB_URL
 c['db_poll_interval'] = 60

Was this you Armen ? Is it to bring the test_master.cfg in line with builders, schedulers etc that already have this ?
Nope! I should have looked for local changes yesterday.
I only modified BuildSlaves.py.
It was a change that Chris suggested to me to fix the issue during the reconfigs last week (and the exact problem is evading my attempts to remember)
Well, do we remove it, or check it in?
Priority: -- → P3
Whiteboard: [buildmasters]
Assignee: nobody → bear
Summary: test-master01 has a local modification in buildbot-configs → make local buildbot-config modification on test-master01 permanent
Attachment #576183 - Flags: review?(catlee)
Comment on attachment 576183 [details] [diff] [review]
make reload(passwords) permanent

if it saves you trouble, take my r+ here :-)
Attachment #576183 - Flags: review+
Attachment #576183 - Flags: review?(catlee) → review+
Comment on attachment 576183 [details] [diff] [review]
make reload(passwords) permanent

committed changeset 5109:4e3386c90964
Attachment #576183 - Flags: checked-in+
Flags: needs-reconfig?
This made it to production today.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Flags: needs-reconfig?
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: