Closed Bug 700614 Opened 12 years ago Closed 12 years ago

Wrong .mozconfig rule in .gitignore

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla11

People

(Reporter: jacek, Assigned: jacek)

Details

(Whiteboard: [inbound])

Attachments

(1 file)

fix v1.0
589 bytes, patch
jrmuizel
: review+
Details | Diff | Splinter Review
Attached patch fix v1.0 — — Splinter Review 
Bug 676599 introduced .gitignore file (which is great), but the pattern for .mozconfig* files was wrong. It was translated from .hgignore:

^\.mozconfig

(note no tailing '$'), so it should end up with leading '*' in .gitignore. Otherwise I get:

# Untracked files:
#   (use "git add <file>..." to include in what will be committed)
#
#       .mozconfig.mk
#       .mozconfig.out


in git status. I've also added leading '/' so that the pattern matches only files in root source directory (just like .hgignore does).
Attachment #572773 - Flags: review?(jmuizelaar)
Attachment #572773 - Flags: review?(jmuizelaar) → review+
https://hg.mozilla.org/mozilla-central/rev/e30ad8b15626
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.