700741 - Add a scriptable way to know if an element is focusable

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Eitan Isaacson [:eeejay]]

Attachment: Add and implement nsIFocusManager.elementIsFocusable

It is useful for extensions to know if an element is focusable without experimenting or reinventing the logic in the platform code. For example the spatial navigation extension that was in mc until recently did a bad job at figuring out what was focusable[1].

1. http://hg.mozilla.org/mozilla-central/file/fa82e3fa46b9/toolkit/spatial-navigation/SpatialNavigation.js

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Neil should probably review the patch.

Comment 2

[Neil Deakin]

Comment on attachment 572919 [details] [diff] [review]
Add and implement nsIFocusManager.elementIsFocusable

>+  *rv = CheckIfFocusable(aContent, aFlags) != nsnull;
>+

Change 'rv' to some other name (such as aIsFocusable). 'rv' is often used as an locally declared nsresult and I was momentarily confused by this.

Comment 3

[Eitan Isaacson [:eeejay]]

Attachment: Add and implement nsIFocusManager.elementIsFocusable

Changed variable name

Comment 4

[David Bolter [:davidb] (NeedInfo me for attention)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0b200d3bd408

Comment 5

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/0b200d3bd408