Closed Bug 700741 Opened 8 years ago Closed 8 years ago

Add a scriptable way to know if an element is focusable

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla11

People

(Reporter: eeejay, Assigned: eeejay)

Details

Attachments

(1 file, 1 obsolete file)

It is useful for extensions to know if an element is focusable without experimenting or reinventing the logic in the platform code. For example the spatial navigation extension that was in mc until recently did a bad job at figuring out what was focusable[1].

1. http://hg.mozilla.org/mozilla-central/file/fa82e3fa46b9/toolkit/spatial-navigation/SpatialNavigation.js
Attachment #572919 - Flags: review?(jst)
OS: Linux → All
Hardware: x86_64 → All
Neil should probably review the patch.
Attachment #572919 - Flags: review?(jst) → review?(enndeakin)
Comment on attachment 572919 [details] [diff] [review]
Add and implement nsIFocusManager.elementIsFocusable

>+  *rv = CheckIfFocusable(aContent, aFlags) != nsnull;
>+

Change 'rv' to some other name (such as aIsFocusable). 'rv' is often used as an locally declared nsresult and I was momentarily confused by this.
Attachment #572919 - Flags: review?(enndeakin) → review+
Changed variable name
Assignee: nobody → eitan
Attachment #572919 - Attachment is obsolete: true
Whiteboard: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/0b200d3bd408
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.