The default bug view has changed. See this FAQ.

Add a scriptable way to know if an element is focusable

RESOLVED FIXED in mozilla11

Status

()

Core
DOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: eeejay, Assigned: eeejay)

Tracking

unspecified
mozilla11
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Created attachment 572919 [details] [diff] [review]
Add and implement nsIFocusManager.elementIsFocusable

It is useful for extensions to know if an element is focusable without experimenting or reinventing the logic in the platform code. For example the spatial navigation extension that was in mc until recently did a bad job at figuring out what was focusable[1].

1. http://hg.mozilla.org/mozilla-central/file/fa82e3fa46b9/toolkit/spatial-navigation/SpatialNavigation.js
(Assignee)

Updated

6 years ago
Attachment #572919 - Flags: review?(jst)
(Assignee)

Updated

6 years ago
OS: Linux → All
Hardware: x86_64 → All
Neil should probably review the patch.
(Assignee)

Updated

6 years ago
Attachment #572919 - Flags: review?(jst) → review?(enndeakin)

Comment 2

6 years ago
Comment on attachment 572919 [details] [diff] [review]
Add and implement nsIFocusManager.elementIsFocusable

>+  *rv = CheckIfFocusable(aContent, aFlags) != nsnull;
>+

Change 'rv' to some other name (such as aIsFocusable). 'rv' is often used as an locally declared nsresult and I was momentarily confused by this.
Attachment #572919 - Flags: review?(enndeakin) → review+
(Assignee)

Comment 3

6 years ago
Created attachment 573523 [details] [diff] [review]
Add and implement nsIFocusManager.elementIsFocusable

Changed variable name
Assignee: nobody → eitan
Attachment #572919 - Attachment is obsolete: true
(Assignee)

Updated

6 years ago
Whiteboard: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/0b200d3bd408
Whiteboard: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/0b200d3bd408
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in before you can comment on or make changes to this bug.