1.39 KB, patch
|Details | Diff | Splinter Review|
Created attachment 572919 [details] [diff] [review] Add and implement nsIFocusManager.elementIsFocusable It is useful for extensions to know if an element is focusable without experimenting or reinventing the logic in the platform code. For example the spatial navigation extension that was in mc until recently did a bad job at figuring out what was focusable. 1. http://hg.mozilla.org/mozilla-central/file/fa82e3fa46b9/toolkit/spatial-navigation/SpatialNavigation.js
Neil should probably review the patch.
Attachment #572919 - Flags: review?(jst) → review?(enndeakin)
Comment on attachment 572919 [details] [diff] [review] Add and implement nsIFocusManager.elementIsFocusable >+ *rv = CheckIfFocusable(aContent, aFlags) != nsnull; >+ Change 'rv' to some other name (such as aIsFocusable). 'rv' is often used as an locally declared nsresult and I was momentarily confused by this.
Attachment #572919 - Flags: review?(enndeakin) → review+
Created attachment 573523 [details] [diff] [review] Add and implement nsIFocusManager.elementIsFocusable Changed variable name
Assignee: nobody → eitan
Attachment #572919 - Attachment is obsolete: true
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in before you can comment on or make changes to this bug.