700775 - Wrong buttons whether to send email confirmation or not

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[Hubert Figuiere [:hub]]

Attachment: screenshot of the dialog.

I accepted a meeting invite.

I got the message "Would you like to send out notification E-Mail now?" with the two buttons [Cancel] [OK].

This is confusing. Buttons should be [No] [Yes].

See screenshot.

Comment 1

[Dricks]

I totally agree with that !

Comment 2

[Dricks]

Problem still there in 1.2b3 
Can you please have a look at it ?
Thanks

Comment 4

[Decathlon]

Attachment: patch - v1

This patch should fix.

Comment 5

[Matthew Mecca [:mmecca]]

Comment on attachment 708787 [details] [diff] [review]
patch - v1

Review of attachment 708787 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. r=mmecca

::: calendar/itip/calItipEmailTransport.js
@@ +214,5 @@
> +                                              null,
> +                                              null,
> +                                              null,
> +                                              cal.calGetString("lightning", "imipSendMail.Outlook2000CompatMode.text", null, "lightning"),
> +                                              inoutCheck) != 0) {

Since a return value of zero evaluates to false, and non-zero values to true, you can just use:

if (Services.prompt.confirmEx(...))

instead of:

if (Services.prompt.confirmEx(...) != 0)

Comment 6

[Decathlon]

(In reply to Matthew Mecca [:mmecca] from comment #5)
 
> Since a return value of zero evaluates to false, and non-zero values to
> true, you can just use:
> 
> if (Services.prompt.confirmEx(...))

Corrected in the changeset.

Pushed to comm-central: http://hg.mozilla.org/comm-central/rev/49fedca3c4b6

Comment 7

[Decathlon]

Matthew, could you also approve the other branches? ;)

Comment 8

[Matthew Mecca [:mmecca]]

Pushed to:
comm-aurora - https://hg.mozilla.org/releases/comm-aurora/rev/06f49a35fc65
comm-beta - https://hg.mozilla.org/releases/comm-beta/rev/6f3f31d3b381

Comment 9

[Matthew Mecca [:mmecca]]

comm-esr17 - https://hg.mozilla.org/releases/comm-esr17/rev/5ef751e0f2fe