700854 - {Media,Image,Video}Document should reference an external stylesheet for use in styling their contents

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

MediaDocument.cpp, ImageDocument.cpp, and VideoDocument.cpp should reference an external stylesheet.

We need to move the styles out to an external stylesheet before we can fix bug 376997.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch for bug 700854

This patch is part of the patch for bug 376997. I have pushed it to the tryserver: https://tbpl.mozilla.org/?tree=Try&rev=5525e6d4e319

There should be no UI changes with this patch, it is just to setup the plumbing for bug 700856.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch for bug 700854

This patch references a ImageDocument.css and VideoDocument.css instead of MediaDocument.css. Styles will be moved to the stylesheets in bug 700856, which I'll land at the same time.

I couldn't push to try because of bug 701232.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 573374 [details] [diff] [review]
Patch for bug 700854

Review of attachment 573374 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/html/document/src/VideoDocument.cpp
@@ +151,5 @@
> +
> +    link->SetAttr(kNameSpaceID_None, nsGkAtoms::href, 
> +                  NS_LITERAL_STRING("resource://gre/res/VideoDocument.css"), true);
> +
> +    head->AppendChildTo(link, false);

Create a superclass helper function to share this code.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch for bug 700854 v1.1

Moved the duplicated code to a function within MediaDocument.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch for bug 700854 v1.1 (renamed css files)

Carrying forward r+ from roc. I've renamed the CSS files to TopLevel*Document.css since they only apply when the synthetic document is top level.

Pushed to try and waiting to land with bug 700856.

https://tbpl.mozilla.org/?tree=Try&rev=816cb0059256

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/integration/fx-team/rev/f828518abaf2

Comment 7

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/mozilla-central/rev/40b0d61c132b

Comment 8

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/mozilla-central/rev/f828518abaf2

Comment 9

[Alfred Kayser]

Why are these in /res/ ? 
Themers (like me) want to theme the background of these pages, so that it would fit better in there theme.