Closed
Bug 700947
Opened 13 years ago
Closed 13 years ago
Hide Test Pilot Feedback button on Aurora until input.mozilla.org works for Thunderbird
Categories
(Thunderbird :: Mail Window Front End, defect)
Tracking
(thunderbird9 fixed, thunderbird10 fixed)
RESOLVED
FIXED
Thunderbird 11.0
People
(Reporter: squib, Assigned: squib)
Details
Attachments
(2 files)
686 bytes,
patch
|
standard8
:
review+
standard8
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
930 bytes,
patch
|
protz
:
review+
standard8
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
Since I gather input.mozilla.org isn't set up to handle Thunderbird's Test Pilot, we should turn off the Feedback button for now. Here's a simple patch to do this.
Attachment #573102 -
Flags: review?(mbanner)
Updated•13 years ago
|
Attachment #573102 -
Flags: review?(mbanner)
Attachment #573102 -
Flags: review+
Attachment #573102 -
Flags: approval-comm-beta+
Attachment #573102 -
Flags: approval-comm-aurora+
Comment 1•13 years ago
|
||
Checked in: http://hg.mozilla.org/comm-central/rev/b171104392c3 http://hg.mozilla.org/releases/comm-aurora/rev/f31549cb18b4 http://hg.mozilla.org/releases/comm-beta/rev/09e02a126f2f
Assignee: nobody → squibblyflabbetydoo
Status: NEW → RESOLVED
Closed: 13 years ago
status-thunderbird10:
--- → fixed
status-thunderbird9:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 11.0
Comment 2•13 years ago
|
||
So I landed this everywhere, but it still didn't seem to work on beta at least: http://tinderbox.mozilla.org/showlog.cgi?log=Thunderbird-Beta/1320845601.1320846225.23849.gz#err0 I did test on aurora before I landed, but admittedly not beta. Jim, any ideas?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 3•13 years ago
|
||
Ah, now I realize the issue. I was just thinking about the feedback button, but to fix the tests as well, we probably need to remove the notification area too, e.g. by commenting out lines 21-23 here: http://mxr.mozilla.org/comm-central/source/mail/app/profile/extensions/tbtestpilot@labs.mozilla.com/content/feedback-browser.xul#21
Comment 4•13 years ago
|
||
Yeah, I'm spamming multiple people, but I'd like to get this landed asap. This passes tests for me if I set the update channel to aurora on my build and apply the patch.
Attachment #573470 -
Flags: review?(squibblyflabbetydoo)
Attachment #573470 -
Flags: review?(sagarwal)
Attachment #573470 -
Flags: review?(jonathan.protzenko)
Comment 5•13 years ago
|
||
Comment on attachment 573470 [details] [diff] [review] Really don't add the feedback button Sounds legit to me :)
Attachment #573470 -
Flags: review?(jonathan.protzenko) → review+
Updated•13 years ago
|
Attachment #573470 -
Flags: review?(squibblyflabbetydoo)
Attachment #573470 -
Flags: review?(sagarwal)
Comment 6•13 years ago
|
||
Comment on attachment 573470 [details] [diff] [review] Really don't add the feedback button Checked in: http://hg.mozilla.org/comm-central/rev/fba69840e3d7 http://hg.mozilla.org/releases/comm-aurora/rev/72c877fda3de http://hg.mozilla.org/releases/comm-beta/rev/97e4f01d55fa
Attachment #573470 -
Flags: approval-comm-beta+
Attachment #573470 -
Flags: approval-comm-aurora+
Updated•13 years ago
|
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•