Last Comment Bug 700993 - Chrome tabs broken after landing of bug 677421
: Chrome tabs broken after landing of bug 677421
: regression
Product: Thunderbird
Classification: Client Software
Component: Mail Window Front End (show other bugs)
: Trunk
: x86_64 Linux
-- normal (vote)
: Thunderbird 11.0
Assigned To: Jonathan Protzenko [:protz]
Depends on:
Blocks: 677421
  Show dependency treegraph
Reported: 2011-11-09 05:06 PST by Jonathan Protzenko [:protz]
Modified: 2011-11-21 01:04 PST (History)
0 users
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

Patch (971 bytes, patch)
2011-11-09 05:06 PST, Jonathan Protzenko [:protz]
squibblyflabbetydoo: review+
standard8: approval‑comm‑aurora+
Details | Diff | Splinter Review

Description User image Jonathan Protzenko [:protz] 2011-11-09 05:06:53 PST
Created attachment 573162 [details] [diff] [review]

Opening chrome tabs is broken. shouldSwitchTo expects a contentPage property, when forwarding the call from the chrome tab type, the parameter is named chromePage, not contentPage.
Comment 1 User image Jim Porter (:squib) 2011-11-09 09:47:02 PST
Comment on attachment 573162 [details] [diff] [review]

Good catch! This looks ok to me, assuming you've tested that it works.
Comment 2 User image Jonathan Protzenko [:protz] 2011-11-10 01:07:59 PST
Yep. Tested that it works :). Thanks for the quick review!
Comment 3 User image Jonathan Protzenko [:protz] 2011-11-19 12:05:47 PST

Mark, can you make sure I did the right things with flags? Thanks :)
Comment 4 User image Mark Banner (:standard8) 2011-11-21 01:04:14 PST
(In reply to Jonathan Protzenko [:protz] from comment #3)
> Mark, can you make sure I did the right things with flags? Thanks :)

Leave the tracking alone, just mark the status as fixed (its only if tracking ver == trunk ver that I tend to cancel that flag due to the tools being not quite good enough).

Note You need to log in before you can comment on or make changes to this bug.