Created attachment 573162 [details] [diff] [review]
Opening chrome tabs is broken. shouldSwitchTo expects a contentPage property, when forwarding the call from the chrome tab type, the parameter is named chromePage, not contentPage.
Comment on attachment 573162 [details] [diff] [review]
Good catch! This looks ok to me, assuming you've tested that it works.
Yep. Tested that it works :). Thanks for the quick review!
Mark, can you make sure I did the right things with flags? Thanks :)
(In reply to Jonathan Protzenko [:protz] from comment #3)
> Mark, can you make sure I did the right things with flags? Thanks :)
Leave the tracking alone, just mark the status as fixed (its only if tracking ver == trunk ver that I tend to cancel that flag due to the tools being not quite good enough).