Closed
Bug 700993
Opened 13 years ago
Closed 13 years ago
Chrome tabs broken after landing of bug 677421
Categories
(Thunderbird :: Mail Window Front End, defect)
Tracking
(thunderbird10+ fixed)
RESOLVED
FIXED
Thunderbird 11.0
People
(Reporter: protz, Assigned: protz)
References
Details
(Keywords: regression)
Attachments
(1 file)
971 bytes,
patch
|
squib
:
review+
standard8
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
Opening chrome tabs is broken. shouldSwitchTo expects a contentPage property, when forwarding the call from the chrome tab type, the parameter is named chromePage, not contentPage.
Attachment #573162 -
Flags: review?(squibblyflabbetydoo)
Updated•13 years ago
|
Comment 1•13 years ago
|
||
Comment on attachment 573162 [details] [diff] [review] Patch Good catch! This looks ok to me, assuming you've tested that it works.
Attachment #573162 -
Flags: review?(squibblyflabbetydoo) → review+
Assignee | ||
Comment 2•13 years ago
|
||
Yep. Tested that it works :). Thanks for the quick review! http://hg.mozilla.org/comm-central/rev/b09edfb0a96b
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•13 years ago
|
Attachment #573162 -
Flags: approval-comm-aurora?
Updated•13 years ago
|
Assignee: nobody → jonathan.protzenko
Target Milestone: --- → Thunderbird 11.0
Updated•13 years ago
|
Attachment #573162 -
Flags: approval-comm-aurora? → approval-comm-aurora+
Assignee | ||
Comment 3•13 years ago
|
||
http://hg.mozilla.org/releases/comm-aurora/rev/5de7b954c1eb Mark, can you make sure I did the right things with flags? Thanks :)
status-thunderbird10:
--- → fixed
tracking-thunderbird10:
+ → ---
Comment 4•13 years ago
|
||
(In reply to Jonathan Protzenko [:protz] from comment #3) > Mark, can you make sure I did the right things with flags? Thanks :) Leave the tracking alone, just mark the status as fixed (its only if tracking ver == trunk ver that I tend to cancel that flag due to the tools being not quite good enough).
tracking-thunderbird10:
--- → +
You need to log in
before you can comment on or make changes to this bug.
Description
•