Chrome tabs broken after landing of bug 677421

RESOLVED FIXED in Thunderbird 11.0

Status

Thunderbird
Mail Window Front End
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: protz, Assigned: protz)

Tracking

({regression})

Trunk
Thunderbird 11.0
x86_64
Linux
regression

Thunderbird Tracking Flags

(thunderbird10+ fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 573162 [details] [diff] [review]
Patch

Opening chrome tabs is broken. shouldSwitchTo expects a contentPage property, when forwarding the call from the chrome tab type, the parameter is named chromePage, not contentPage.
Attachment #573162 - Flags: review?(squibblyflabbetydoo)
Blocks: 677421
tracking-thunderbird10: --- → +
Keywords: regression

Comment 1

6 years ago
Comment on attachment 573162 [details] [diff] [review]
Patch

Good catch! This looks ok to me, assuming you've tested that it works.
Attachment #573162 - Flags: review?(squibblyflabbetydoo) → review+
(Assignee)

Comment 2

6 years ago
Yep. Tested that it works :). Thanks for the quick review!

http://hg.mozilla.org/comm-central/rev/b09edfb0a96b
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Updated

6 years ago
Attachment #573162 - Flags: approval-comm-aurora?
Assignee: nobody → jonathan.protzenko
Target Milestone: --- → Thunderbird 11.0
Attachment #573162 - Flags: approval-comm-aurora? → approval-comm-aurora+
(Assignee)

Comment 3

6 years ago
http://hg.mozilla.org/releases/comm-aurora/rev/5de7b954c1eb

Mark, can you make sure I did the right things with flags? Thanks :)
status-thunderbird10: --- → fixed
tracking-thunderbird10: + → ---
(In reply to Jonathan Protzenko [:protz] from comment #3)
> Mark, can you make sure I did the right things with flags? Thanks :)

Leave the tracking alone, just mark the status as fixed (its only if tracking ver == trunk ver that I tend to cancel that flag due to the tools being not quite good enough).
tracking-thunderbird10: --- → +
You need to log in before you can comment on or make changes to this bug.