701075 - Fix tests to reduce warnings being logged

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Comment 1

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/257

Pointer to Github pull-request

Comment 2

[Alexandre Poirot [:ochameau]]

Comment on attachment 573243 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/257

r+ with pull request comments addressed.

Comment 3

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

https://github.com/mozilla/addon-sdk/commit/4a7ad7f428b9d491d324126883bf6aa5300d5a7d

Comment 4

[Myk Melez [:myk] [@mykmelez]]

If I apply the patch in bug 694806, tests pass, but I still see one warning:

(addon-sdk)mykbook:api-utils myk$ cfx test -f window-utils
Using binary at '/Applications/Nightly.app/Contents/MacOS/firefox-bin'.
Using profile at '/var/folders/bN/bN4Z5w6UEdC60cFgLX32NU+++TI/-Tmp-/tmpAKl9Vd.mozrunner'.
Running tests on Firefox 11.0a1/Gecko 11.0a1 ({ec8030f7-c20a-464f-9b0e-13a3a9e97384}) under darwin/x86.
.......console: [JavaScript Warning: "reference to undefined property desc1.get" {file: "resource://122a4511-074e-4186-a848-b5ccf8bafc0b-at-jetpack-api-utils-lib/cuddlefish.js -> resource://122a4511-074e-4186-a848-b5ccf8bafc0b-at-jetpack-api-utils-lib/traits/core.js" line: 54}]

Comment 5

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

That's so strange I don't see this warning on my machine. I assume that can be fixed by changing these:

https://github.com/mozilla/addon-sdk/blob/master/packages/api-utils/tests/test-traits-core.js#L44-45

'get' in desc1 && desc1.get,
'get' in desc2 && desc1.get 

And so for all the other asserts.

Comment 6

[Myk Melez [:myk] [@mykmelez]]

(In reply to Irakli Gozilalishvili [:irakli] [:gozala] from comment #5)
> That's so strange I don't see this warning on my machine. I assume that can
> be fixed by changing these:
> 
> https://github.com/mozilla/addon-sdk/blob/master/packages/api-utils/tests/
> test-traits-core.js#L44-45
> 
> 'get' in desc1 && desc1.get,
> 'get' in desc2 && desc1.get 
> 
> And so for all the other asserts.

Hmm, yeah, that would make the warning go away, but is it possible that there's an underlying problem that would be masked by such a change?

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Not sure if it's related to this bug landing, but sometime in the last day or so, I started seeing this error pop up when running cfx test:
console: [JavaScript Error: "no element found" {file: "http://localhost/safebrowsing-dummy/newkey" line: 1}]

Doesn't matter which tests are running, I saw it with request, httpd, and window-utils.
(I'm also seeing window-utils pass 15 of 17 tests, not 19 of 21 like that other bug says. Did that get changed recently?)

Comment 8

[Myk Melez [:myk] [@mykmelez]]

(In reply to Wes Kocher (:KWierso) (Jetpack Bugmaster) from comment #7)
> (I'm also seeing window-utils pass 15 of 17 tests, not 19 of 21 like that
> other bug says. Did that get changed recently?)

Yes, that was a temporary consequence of this bug fix.  It should be 20 of 20 now that the fix for bug 694806 has landed.


(In reply to Myk Melez [:myk] [@mykmelez] from comment #4)
> If I apply the patch in bug 694806, tests pass, but I still see one warning:

Filed as bug 702836.