701078 - no images in [Preview Content] when editing articles

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task)

Description

[u375495]

Attachment: Preview Content

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:8.0) Gecko/20100101 Firefox/8.0
Build ID: 20111104165243

Steps to reproduce:

when I edit an article 
(for example https://support.mozilla.com/en-US/kb/Enabling%20and%20disabling%20cookies/edit#preview)
and than use the button "Preview Content" - I can't see any images in this article

Comment 1

[u375495]

Attachment: PreviewContent01.png

Comment 2

[Ricky Rosario [:rrosario, :r1cky]]

Ah, this is most likely related to the new lazy loading of images.

Comment 3

[Kadir Topal [:atopal]]

Can we get a test for this? It affects localizers a lot.

Comment 4

[Tanay Gavankar [:tgavankar]]

Seems like since the HTML is being previewed without a new page load, the lazyloading binding of images isn't occurring (since the initial function call occurs on document.ready). The fix should just be a matter of adding the lazyload init (in particular, $('img.lazy').lazyload()) to where ever the preview html is inserted.

Comment 5

[Tanay Gavankar [:tgavankar]]

Fixed in https://github.com/jsocol/kitsune/commit/11b0c10.

As for regression tests, this seems like it's more suited for selenium.

Comment 7

[Verdi [:verdi] Best to slack me]

I did an empty edit of how to set the home page on -dev https://support-dev.allizom.org/en-US/kb/How+to+set+the+home+page and no images show up in preview. I also added a new image from -dev media gallery and it doesn't show up on preview either.

Comment 8

[Verdi [:verdi] Best to slack me]

Just to clarify so it's here in the bug:
STR:
1. Got to https://support-dev.allizom.org/en-US/kb/How+to+set+the+home+page
2. Click Edit Article
3. Click the preview button
Results: no images show up in the preview

Comment 9

[Ricky Rosario [:rrosario, :r1cky]]

support-dev is in the middle of some changes related to how it is deployed and doesn't have the latest code at the moment. Stage does have it and seems to be working correctly:
https://support.allizom.org/en-US/kb/How+to+set+the+home+page/edit

This is what will be shipping next Tuesday. Reopen if you see any issues on stage.

Comment 10

[Rebecca Billings [:rbillings]]

Verified that it works correctly, with images in a KB preview on support.allizom.org