701098 - Taskbar window registration call to NS_GetSpecialDirectory is using the wrong profile constant

Status: VERIFIED FIXED

(Core :: Widget: Win32, defect)

Description

[Jim Mathies [:jimm]]

Code is here:

http://mxr.mozilla.org/mozilla-central/source/widget/src/windows/WinTaskbar.cpp#280

The result returned is:

"C:\Program Files (x86)\Nightly\defaults\profile"

This works fine with debug builds but release builds get this default profile directory. Not sure what's going on here but I'd like to get it fixed and landed on aurora before the next merge date.

Comment 1

[Jim Mathies [:jimm]]

So debug builds also point to the default, it's just that those directories happen to exist, so the call succeeds. Since we are calling this as late as we can (the creation of the first nsWindow object) we may not be able to fix this. If not, I'll switch this bug to backing out the code.

Comment 2

[Jim Mathies [:jimm]]

 I think the problem is the use of the wrong constant for the profile dir. Looks like NS_APP_PROFILE_DEFAULTS_50_DIR isn't the right match.

Comment 3

[Jim Mathies [:jimm]]

Attachment: patch

bsmedberg, hoping you know if this is the right constant or not. Testing shows this yields the real profile directory, which was what I wanted the first time around.

Comment 4

[Jim Mathies [:jimm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d2558deedcca

Comment 5

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/d2558deedcca

Comment 6

[Jim Mathies [:jimm]]

Comment on attachment 573260 [details] [diff] [review]
patch

This is a touch-up fix for some code that is in the current Aurora build. Would really like to get it in since it makes a new hidden pref feature work. Risk level is super low.

Comment 7

[Jim Mathies [:jimm]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/35805ea8da65

Comment 8

[u279076]

Is this something QA needs to verify?

Comment 9

[Jim Mathies [:jimm]]

(In reply to Anthony Hughes, Mozilla QA (irc: ashughes) from comment #8)
> Is this something QA needs to verify?

You can confirm this by setting the taskbar.grouping.useprofile bool pref and verifying that the browser groups separately on the taskbar from the default install. Normally we group based on an id generated using the install path, with taskbar.grouping.useprofile set we group based on the profile path.

Comment 10

[Ioana (away)]

Verified as fixed on:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0) Gecko/20100101 Firefox/10.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0a2) Gecko/20120104 Firefox/11.0a2
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:12.0a1) Gecko/20120104 Firefox/12.0a1

STR:
1. Create multiple Firefox profiles.
2. Add the taskbar.grouping.useprofile bool pref to about:config and set it as "true" for at least one profile.
3. Launch multiple instances of Firefox using different profiles for each instance (multiple windows per profile too).

The windows from the profiles with taskbar.grouping.useprofile set are grouped separately on the taskbar. The windows from all the other profiles are grouped together on the taskbar.