Closed
Bug 701169
Opened 13 years ago
Closed 13 years ago
Talos should have a basic .gitignore file
Categories
(Testing :: Talos, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: wlach, Assigned: wlach)
Details
Attachments
(1 file)
342 bytes,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
I'm currently importing talos into eideticker via a git submodule (imported from the git mirror of talos here: https://github.com/mozilla/talos). Similar to what we already do for the git mirror of m-c, it would be convenient to have a simple .gitignore in the root of the repository so that the output of "git status" is a bit clearer.
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → wlachance
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #573300 -
Flags: review?(jmaher)
Comment 2•13 years ago
|
||
Comment on attachment 573300 [details] [diff] [review] Basic .gitignore for talos Review of attachment 573300 [details] [diff] [review]: ----------------------------------------------------------------- browser_output.txt seems like overkill. In that same regard what about remoteapp.ini? Otherwise a great addition to the talos repository.
Attachment #573300 -
Flags: review?(jmaher) → review+
Assignee | ||
Comment 3•13 years ago
|
||
(In reply to Joel Maher (:jmaher) from comment #2) > Comment on attachment 573300 [details] [diff] [review] [diff] [details] [review] > Basic .gitignore for talos > > Review of attachment 573300 [details] [diff] [review] [diff] [details] [review]: > ----------------------------------------------------------------- > > browser_output.txt seems like overkill. In that same regard what about > remoteapp.ini? Otherwise a great addition to the talos repository. wrt browser_output.txt. Don't blame me, I'm just copying the existing behaviour in .hgignore. :) Seriously, I think it's ok to ignore it, since it falls under the definition of an automatically generated file. I can't see how we'd ever want to commit it or otherwise pay attention to it version-control wise. wrt remoteapp.ini, yes, we should be ignoring this (along with a bunch of other mobile-specific files) in both .hgignore and .gitignore though I think this would be better addressed in a separate bug. If this sounds ok, could you push when you get the chance? Thanks!
Assignee | ||
Comment 4•13 years ago
|
||
Pushed: http://hg.mozilla.org/build/talos/rev/c338c13b79ac
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•