[homepage] Some teams are missing a real name

RESOLVED FIXED

Status

Webtools
Elmo
RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: peterbe, Assigned: peterbe)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
For example, on https://l10n-stage-sj.mozilla.org/teams/af it says::

 <h1>Mozilla Localization Team None</h1>
(Assignee)

Comment 1

6 years ago
Correction: they're all missing it.
(Assignee)

Comment 2

6 years ago
Half-way through doing the hotfix I figured out it's because django_compressor somehow overrides the template context variable 'name'. Not cool :(

https://github.com/jezdez/django_compressor/issues/156

Comment 3

6 years ago
yikes. are there more variables it uses?
(Assignee)

Comment 4

6 years ago
Created attachment 573369 [details] [diff] [review]
referencing locale name differently to avoid bug in django_compressor
Attachment #573369 - Flags: review?(l10n)
(Assignee)

Comment 5

6 years ago
(In reply to Axel Hecht [:Pike] from comment #3)
> yikes. are there more variables it uses?

Nope. Looked deep into it but eventually decided it's too complex for me to try to fix it for jezdez. I'm sure he can fix it by changing "name" to "block_name". Also I don't know how to run his testsuite. 
Here's the culprit: https://github.com/jezdez/django_compressor/blob/develop/compressor/templatetags/compress.py#L81

Updated

6 years ago
Attachment #573369 - Flags: review?(l10n) → review+

Updated

6 years ago
Depends on: 662303
(Assignee)

Comment 7

6 years ago
Deployed and verified.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

4 years ago
Assignee: nobody → peterbe
You need to log in before you can comment on or make changes to this bug.