in https://github.com/whimboo/mozmill-environment/pull/1 a number of the calls to the OS have been created to do shell commands. This should be converted to idiomatic python so that it is easier to read and follow
Assignee: nobody → madbyk
Status: NEW → ASSIGNED
We would need that fixed for our further work on bug 701215, so that we can mostly unify all the different build scripts. Burak, you have assigned yourself without a comment. Are you planning to work on this bug in the near future? We would love it.
OS: Mac OS X → All
Hardware: x86 → All
(In reply to Henrik Skupin (:whimboo) from comment #1) > We would need that fixed for our further work on bug 701215, so that we can > mostly unify all the different build scripts. > > Burak, you have assigned yourself without a comment. Are you planning to > work on this bug in the near future? We would love it. Henrik, Yeah, sorry for not commenting. My aim is to submit a patch till the end of this week. Is it good enough for you or do you need someone faster? =)
That would be perfect. No rush. There are way more dependencies marked on bug 701215 I can look at. Thanks for stepping in here!
I am working on a patch though there are still some code specific to Windows platform like "os.environ['WINDIR']" etc. Are these okay or should we do something else(which I can't think of right now)?
That's fine for now. Each platform will have its specific tasks to perform. Even when we start the work on a single build script for all platforms we will have to specialize such code.
I made a pull request: https://github.com/whimboo/mozmill-environment/pull/3
This was fixed some time ago. See pull request
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
This has been fixed a long time ago.
Component: Mozmill → Mozmill Automation
Product: Testing → Mozilla QA
QA Contact: mozmill → mozmill-automation
Version: Trunk → unspecified
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.