701270 - Remove nsNSSErrors::getDefaultErrorStringName and use PR_ErrorToName instead

Status: RESOLVED WORKSFORME

(Core :: Security: PSM, defect)

Description

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

NSS 3.13.2 will add some new error codes. Instead of updating nsNSSErrors::getDefaultErrorStringName, we should just use use PR_ErrorToName, since bug 172051 caused PR_ErrorToName to work for NSS.

I am presumptuously assigning this to Kai since he knows more about this code than me, in particular why this suggestion might be a bad idea.

Comment 1

[Kai Engert [:KaiE:]]

reassign bug owner.
mass-update-kaie-20120918

Comment 2

[Elio Maldonado]

You may want to consider the convenience macro:
$ grep -r PORT_ErrorToString security/nss/lib/util/secport.h
#define PORT_ErrorToString(err) PR_ErrorToString((err), PR_LANGUAGE_I_DEFAULT)

Comment 3

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

This change was already made as part of Bug 738457:

http://hg.mozilla.org/mozilla-central/rev/5b8f9effd8ca