701274 - JSD's jsd_ThrowHandler uses value from wrong enumeration

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jim Blandy :jimb]

Although jsd_ThrowHandler is declared to return a JSTrapStatus --- as expected for functions used for JSDebugHooks::throwHook --- the code may actually return JSD_HOOK_RETURN_CONTINUE_THROW, which is not a valid JSTrapStatus value.

This turns out to not have any effect: the js/src code that calls throwHook happens to treat bogus JSTrapStatus values as equivalent to JSTRAP_CONTINUE, which is what jsd_ThrowHandler should be returning. And when there is a JSDContext::throwHook established, jsd_ThrowHandler passes through the return value of jsd_CallExecutionHook, which uses JSTrapStatus properly.

But I would like to tighten up js/src to check that hooks return valid JSTrapStatus values, so I would like to fix jsd_ThrowHandler.

Comment 1

[Jim Blandy :jimb]

(Simple patch forthcoming...)

Comment 2

[Jim Blandy :jimb]

Attachment: Make jsd_ThrowHandler return the proper JSTrapStatus value, not JSD_HOOK_RETURN_CONTINUE_THROW.

The try server is evaluating this patch, along with the patches for bug 687683 and bug 700070, here:
https://tbpl.mozilla.org/?tree=Try&rev=ec00649f1af6

Comment 3

[Jim Blandy :jimb]

Try server liked it, so here you go.

Comment 4

[Jim Blandy :jimb]

https://hg.mozilla.org/integration/mozilla-inbound/rev/26e489b81e7f

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/26e489b81e7f