701275 - [ga-IE] Search Engine modification for Thunderbird

Status: RESOLVED FIXED

(Mozilla Localizations :: ga-IE / Irish, defect)

Description

[Kevin Scannell]

I'd like to use the same search engine configuration as we use in Irish Firefox.  Patch attached.

Comment 1

[Kevin Scannell]

Attachment: Search plugins for Irish

Comment 2

[Justin Wood (:Callek)]

Comment on attachment 573415 [details] [diff] [review]
Search plugins for Irish

Mark, this was original requested as approval-comm-aurora, but contact went to SeaMonkey team, so I suspect that was wrong and you wouldn't have noticed this.

Redirecting the request to a review-request to you, since I bet the person who needs to check is, in fact, yourself.

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 573415 [details] [diff] [review]
Search plugins for Irish

Review of attachment 573415 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch, sorry for the delay in response. This looks generally good, except we're removing some of the parameters for now whilst we confirm what we are using. If/when they need to be added back, we'll file bugs.

::: mail/searchplugins/amazon-en-GB.xml
@@ +6,5 @@
> +<Url type="text/html" method="GET" template="http://www.amazon.co.uk/exec/obidos/external-search/">
> +  <Param name="field-keywords" value="{searchTerms}"/>
> +  <Param name="mode" value="blended"/>
> +  <Param name="tag" value="firefox-uk-21"/>
> +  <Param name="sourceid" value="Mozilla-search"/>

Please remove the sourceid. We may be changing it, or having a different value - we're not quite sure yet.

::: mail/searchplugins/wikipedia-ga-IE.xml
@@ +8,5 @@
> +  <Param name="search" value="{searchTerms}"/>
> +</Url>
> +<Url type="text/html" method="GET" template="http://ga.wikipedia.org/wiki/Special:Search">
> +  <Param name="search" value="{searchTerms}"/>
> +  <Param name="sourceid" value="Mozilla-search"/>

Please remove the sourceid for now.

::: mail/searchplugins/yahoo-en-GB.xml
@@ +7,5 @@
> + template="http://ff.search.yahoo.com/gossip?output=fxjson&amp;command={searchTerms}" />
> +<Url type="text/html" method="GET" template="http://uk.search.yahoo.com/search">
> +  <Param name="p" value="{searchTerms}"/>
> +  <Param name="ei" value="UTF-8"/>
> +  <MozParam name="fr" condition="pref" pref="yahoo-fr" />

Please remove the MozParam.

Comment 4

[Kevin Scannell]

Committed with these three changes, thanks!
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ga-IE/rev/51b6733785b2

Comment 5

[Mark Banner (:standard8)]

Thanks, don't forget to sign-off on aurora when you're ready.

Comment 6

[Mark Banner (:standard8)]

I just noticed these two lines in your list.txt:

answers
creativecommons

These were removed in Firefox and aren't in Thunderbird, so your build will be braking.

Please can you remove them from aurora and beta.

Comment 7

[Kevin Scannell]

Removed from aurora and beta.

Comment 8

[Mark Banner (:standard8)]

The changes look good. Can you re-submit your sign-offs for Beta (and aurora assuming you're ready to sign off there)?

Thanks