[ga-IE] Search Engine modification for Thunderbird

RESOLVED FIXED

Status

RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: kscanne, Assigned: kscanne)

Tracking

({productization})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
I'd like to use the same search engine configuration as we use in Irish Firefox.  Patch attached.
(Assignee)

Comment 1

7 years ago
Created attachment 573415 [details] [diff] [review]
Search plugins for Irish
Attachment #573415 - Flags: approval-comm-aurora?
Comment on attachment 573415 [details] [diff] [review]
Search plugins for Irish

Mark, this was original requested as approval-comm-aurora, but contact went to SeaMonkey team, so I suspect that was wrong and you wouldn't have noticed this.

Redirecting the request to a review-request to you, since I bet the person who needs to check is, in fact, yourself.
Attachment #573415 - Flags: approval-comm-aurora? → review?(mbanner)
Comment on attachment 573415 [details] [diff] [review]
Search plugins for Irish

Review of attachment 573415 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch, sorry for the delay in response. This looks generally good, except we're removing some of the parameters for now whilst we confirm what we are using. If/when they need to be added back, we'll file bugs.

::: mail/searchplugins/amazon-en-GB.xml
@@ +6,5 @@
> +<Url type="text/html" method="GET" template="http://www.amazon.co.uk/exec/obidos/external-search/">
> +  <Param name="field-keywords" value="{searchTerms}"/>
> +  <Param name="mode" value="blended"/>
> +  <Param name="tag" value="firefox-uk-21"/>
> +  <Param name="sourceid" value="Mozilla-search"/>

Please remove the sourceid. We may be changing it, or having a different value - we're not quite sure yet.

::: mail/searchplugins/wikipedia-ga-IE.xml
@@ +8,5 @@
> +  <Param name="search" value="{searchTerms}"/>
> +</Url>
> +<Url type="text/html" method="GET" template="http://ga.wikipedia.org/wiki/Special:Search">
> +  <Param name="search" value="{searchTerms}"/>
> +  <Param name="sourceid" value="Mozilla-search"/>

Please remove the sourceid for now.

::: mail/searchplugins/yahoo-en-GB.xml
@@ +7,5 @@
> + template="http://ff.search.yahoo.com/gossip?output=fxjson&amp;command={searchTerms}" />
> +<Url type="text/html" method="GET" template="http://uk.search.yahoo.com/search">
> +  <Param name="p" value="{searchTerms}"/>
> +  <Param name="ei" value="UTF-8"/>
> +  <MozParam name="fr" condition="pref" pref="yahoo-fr" />

Please remove the MozParam.
Attachment #573415 - Flags: review?(mbanner) → review+
(Assignee)

Comment 4

7 years ago
Committed with these three changes, thanks!
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ga-IE/rev/51b6733785b2
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Thanks, don't forget to sign-off on aurora when you're ready.
I just noticed these two lines in your list.txt:

answers
creativecommons

These were removed in Firefox and aren't in Thunderbird, so your build will be braking.

Please can you remove them from aurora and beta.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 7

7 years ago
Removed from aurora and beta.
The changes look good. Can you re-submit your sign-offs for Beta (and aurora assuming you're ready to sign off there)?

Thanks
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.