Closed
Bug 701292
Opened 13 years ago
Closed 13 years ago
clicks are transmitted when panning
Categories
(Firefox for Android Graveyard :: General, defect, P1)
Tracking
(firefox11 fixed, fennec11+)
VERIFIED
FIXED
People
(Reporter: fabrice, Assigned: fabrice)
Details
Attachments
(3 files)
2.26 KB,
patch
|
pcwalton
:
review-
|
Details | Diff | Splinter Review |
1.22 KB,
patch
|
pcwalton
:
review+
|
Details | Diff | Splinter Review |
3.15 KB,
patch
|
pcwalton
:
review+
|
Details | Diff | Splinter Review |
That makes browsing quite difficult ;)
Assignee | ||
Comment 1•13 years ago
|
||
That seems to work fine here, but the constants at least probably need some tweaking.
Assignee: nobody → fabrice
Attachment #573429 -
Flags: review?(pwalton)
Comment 2•13 years ago
|
||
Comment on attachment 573429 [details] [diff] [review] patch Review of attachment 573429 [details] [diff] [review]: ----------------------------------------------------------------- ::: embedding/android/gfx/LayerController.java @@ +298,5 @@ > + Log.i("Gecko", "Setting mLastEvent"); > + mLastX = event.getRawX(); > + mLastY = event.getRawY(); > + mLastTime = event.getEventTime(); > + } This duplicates some logic that the pan/zoom controller already has. I think it'd be better to move this logic to a new method PanZoomController.shouldCallTouchListener(). It can possibly be as simple as: return mState == PANNING || mState == PANNING_HOLD || mState == PINCHING; Then just have the LayerController call that method on mPanZoomController to determine whether to call the touch listener.
Attachment #573429 -
Flags: review?(pwalton) → review-
Comment 3•13 years ago
|
||
Was discussing this somewhat with wesj yesterday. I had a patch for this that I was using locally that I think is a good temporary fix for this issue, until wesj revisits this code for touch events.
Attachment #573532 -
Flags: review?(pwalton)
Comment 4•13 years ago
|
||
(In case it's not clear why the patch works, it's because the PanZoomController's onTouchEnd returns true after a pan. This effectively eats the touch-up event, and so what gecko gets is just the touch-down, which is not sufficient for a click. Without a pan, however, it gets both touch-up and touch-down and so triggers a click).
Comment 5•13 years ago
|
||
Comment on attachment 573532 [details] [diff] [review] Temp fix for click while panning Review of attachment 573532 [details] [diff] [review]: ----------------------------------------------------------------- Clever! r+ with a comment that explains that this is temporary.
Attachment #573532 -
Flags: review?(pwalton) → review+
Updated•13 years ago
|
Priority: -- → P1
Comment 6•13 years ago
|
||
Just as an update, there is an issue with my patch which makes it really hard to click on links sometimes. I believe this happens because even a one-pixel movement between the touch-down and touch-up will send the PanZoomController into pan mode and kill the click. The best way to fix this (and which would be good in general) is to have a movement threshold in the PanZoomController below which a pan doesn't actually get started (e.g. you need to drag 3-4 pixels before it starts panning). I can do this in a separate patch.
Comment 7•13 years ago
|
||
Attachment #574290 -
Flags: review?(pwalton)
Comment 8•13 years ago
|
||
Comment on attachment 574290 [details] [diff] [review] Add a pan thresold Review of attachment 574290 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #574290 -
Flags: review?(pwalton) → review+
Comment 9•13 years ago
|
||
http://hg.mozilla.org/projects/birch/rev/ce4ebd1d2c9f http://hg.mozilla.org/projects/birch/rev/6da7470b607c
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 10•13 years ago
|
||
Verified fixed on: Mozilla/5.0 (Android;Linux armv7l;rv:11.0a1)Gecko/20111116 Firefox/11.0a1 Fennec/11.0a1 Devices: Motorola Droid 2 OS: Android 2.3.3
Status: RESOLVED → VERIFIED
Updated•12 years ago
|
tracking-fennec: --- → 11+
Updated•12 years ago
|
status-firefox11:
--- → fixed
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•