701385 - Only bump questions (update the updated field) on new replies

Status: RESOLVED FIXED

(support.mozilla.org :: Questions, task, P2)

Description

[:ibai]

Actual behavior:

- Solution is chosen on a thread that it's in the second page
- Thread is moved to the first position 

Proposed behavior:

- Solution is chosen on a thread that it's on the second page
- Thread doesn't change position. 

I understand that this is because a solution is considered an update to the thread and the list is ordered by "last update" instead of "last answer".

Comment 1

[Ricky Rosario [:rrosario, :r1cky]]

Did we get any agreement on this proposal? It makes sense to me.

Comment 2

[:ibai]

This is pretty disruptive for contributors. Maybe we should change the whole bumping behavior to only mark as "updated" when there's a reply and simplify the logic (i think this is the last piece that marks the thread as updated though)

Comment 3

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to :ibai from comment #2)
> This is pretty disruptive for contributors. Maybe we should change the whole
> bumping behavior to only mark as "updated" when there's a reply and simplify
> the logic (i think this is the last piece that marks the thread as updated
> though)

Agreed. I think it should only bump on a new reply and nothing else (edits, solving, voting, etc should not bump)

Comment 4

[:ibai]

Do you want to change the scope of this bug and we can execute?

Comment 5

[Ricky Rosario [:rrosario, :r1cky]]

Changing title to reflect what we want to do based on Comment 3

Comment 6

[Ricky Rosario [:rrosario, :r1cky]]

Making this a 2pter to account for time to add tests for most or all the different cases.

Comment 7

[Michael Cooper [:mythmon]]

https://github.com/mozilla/kitsune/pull/725

Comment 8

[Michael Cooper [:mythmon]]

https://github.com/mozilla/kitsune/commit/3ce166af23f160b8a38456a973674dd0df9ffb5e

Comment 9

[Michael Cooper [:mythmon]]

Will pushed this change at about 9:30 eastern time.