Closed Bug 701423 Opened 9 years ago Closed 9 years ago

Log the id and classes of an element in cycle collector dumps

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: mccr8, Assigned: smaug)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Blocks: 723783
Assignee: nobody → bugs
Attached patch patchSplinter Review
Attachment #594415 - Flags: review?(continuation)
Comment on attachment 594415 [details] [diff] [review]
patch

Review of attachment 594415 [details] [diff] [review]:
-----------------------------------------------------------------

It looks okay to me, but I don't know anything about this id/class stuff, or these string functions, so you should probably get somebody else to look at it.
Attachment #594415 - Flags: review?(continuation) → feedback+
Attachment #594415 - Flags: review?(jonas)
Comment on attachment 594415 [details] [diff] [review]
patch

Review of attachment 594415 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/base/src/nsGenericElement.cpp
@@ +4678,4 @@
>      }
> +
> +    const char* nsuri = nsid < ArrayLength(kNSURIs) ? kNSURIs[nsid] : "";
> +    PR_snprintf(name, sizeof(name), "nsGenericElement%s %s%s%s %s",

Space before the first %s?
Attachment #594415 - Flags: review?(jonas) → review+
Nope. there is the silly namespace table which has spaces. I didn't want to change it.
https://hg.mozilla.org/mozilla-central/rev/7d80f315802f
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.