Last Comment Bug 701423 - Log the id and classes of an element in cycle collector dumps
: Log the id and classes of an element in cycle collector dumps
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: Core & HTML (show other bugs)
: Trunk
: All All
: -- normal (vote)
: ---
Assigned To: Olli Pettay [:smaug]
:
Mentors:
Depends on:
Blocks: 723783 700645
  Show dependency treegraph
 
Reported: 2011-11-10 10:02 PST by Andrew McCreight [:mccr8]
Modified: 2012-02-11 03:14 PST (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (1.89 KB, patch)
2012-02-04 03:15 PST, Olli Pettay [:smaug]
jonas: review+
continuation: feedback+
Details | Diff | Splinter Review

Description Andrew McCreight [:mccr8] 2011-11-10 10:02:07 PST

    
Comment 1 Olli Pettay [:smaug] 2012-02-04 03:15:31 PST
Created attachment 594415 [details] [diff] [review]
patch
Comment 2 Andrew McCreight [:mccr8] 2012-02-04 08:05:18 PST
Comment on attachment 594415 [details] [diff] [review]
patch

Review of attachment 594415 [details] [diff] [review]:
-----------------------------------------------------------------

It looks okay to me, but I don't know anything about this id/class stuff, or these string functions, so you should probably get somebody else to look at it.
Comment 3 Jonas Sicking (:sicking) PTO Until July 5th 2012-02-11 00:31:45 PST
Comment on attachment 594415 [details] [diff] [review]
patch

Review of attachment 594415 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/base/src/nsGenericElement.cpp
@@ +4678,4 @@
>      }
> +
> +    const char* nsuri = nsid < ArrayLength(kNSURIs) ? kNSURIs[nsid] : "";
> +    PR_snprintf(name, sizeof(name), "nsGenericElement%s %s%s%s %s",

Space before the first %s?
Comment 4 Olli Pettay [:smaug] 2012-02-11 02:57:09 PST
Nope. there is the silly namespace table which has spaces. I didn't want to change it.
Comment 5 Olli Pettay [:smaug] 2012-02-11 03:14:30 PST
https://hg.mozilla.org/mozilla-central/rev/7d80f315802f

Note You need to log in before you can comment on or make changes to this bug.