701423 - Log the id and classes of an element in cycle collector dumps

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

Comment 2

[Andrew McCreight [:mccr8]]

Comment on attachment 594415 [details] [diff] [review]
patch

Review of attachment 594415 [details] [diff] [review]:
-----------------------------------------------------------------

It looks okay to me, but I don't know anything about this id/class stuff, or these string functions, so you should probably get somebody else to look at it.

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 594415 [details] [diff] [review]
patch

Review of attachment 594415 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/base/src/nsGenericElement.cpp
@@ +4678,4 @@
>      }
> +
> +    const char* nsuri = nsid < ArrayLength(kNSURIs) ? kNSURIs[nsid] : "";
> +    PR_snprintf(name, sizeof(name), "nsGenericElement%s %s%s%s %s",

Space before the first %s?

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Nope. there is the silly namespace table which has spaces. I didn't want to change it.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/mozilla-central/rev/7d80f315802f