701450 - Please load all images for a platform at the same time

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task)

Description

[Verdi [:verdi] Best to slack me]

Bug 632809 introduced "lazy loading" of images which is an awesome idea. However, now as you scroll down an article images seem to pop up. It's distracting and not very nice looking. If possible it would great if we could load all the images for whatever is selected in the "help with" menu all at once so they are loaded with the page and not as you scroll down the page.

Comment 1

[James Socol [:jsocol, :james]]

What if we were more aggressive about loading things before they reach the screen? I ask because that's an easier change that should accomplish the same goal of being less distracting.

Comment 2

[Verdi [:verdi] Best to slack me]

I don't really know what that means but it sounds good to me if you think that solves the issue.

Comment 3

[Tanay Gavankar [:tgavankar]]

That's just a matter of changing the threshold option in lazyload.js, maybe we should just make it a lot bigger.

Comment 4

[Tanay Gavankar [:tgavankar]]

Done in https://github.com/jsocol/kitsune/commit/57e76f16.

Comment 5

[Rebecca Billings [:rbillings]]

What is the best way to verify this? I can see the images in this article load more quickly in stage than prod: https://support.allizom.org/en-US/kb/Installing%20Firefox%20on%20Mac

But I wasn't sure that was sufficient.

Comment 6

[Tanay Gavankar [:tgavankar]]

Emulating a usual user's scrolling speed, just scroll down the page and make sure you don't see images popping up out of nowhere (which is what currently happens). It's not an increase in the loading speed itself, but rather the patch simply forces the images to start to load earlier.

Comment 7

[Rebecca Billings [:rbillings]]

Verified images load smoothly & quickly, without popping out of nowhere