[Firefox Live] Replace social buttons with static buttons

VERIFIED FIXED in 4.7

Status

Websites
Other
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: williamr, Assigned: pascalc)

Tracking

unspecified
Dependency tree / graph

Details

(Whiteboard: r=98005,98035 b=trunk, URL)

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
Firefox Live currently has iframe buttons on the main page for "Like" (Facebook) and "Tweet" (Twitter). Given the privacy implications with loading these buttons (bug 701094), we'd like to replace them with static, local buttons that pass query strings to the FB/Twitter service URLs.

It's important that we still measure the number of shares from these buttons as best we can, so we'd like to use Webtrends javascript tags to measure how many times these buttons are clicked on.

This also impacts the Facebook "Like" button on the returning user overlay. We can replace this with a static image linking to http://www.facebook.com/Firefox

Laura, can you provide the Webtrends code for measuring clicks of 3 buttons (2 Facebook, 1 Twitter)?

Pascal, please let us know if there are any L10n considerations. I'd prefer to not add any new strings if possible and just use sharing/liking icons.

Silverorange, can handle the implementation piece.
(Assignee)

Comment 1

7 years ago
yes, this has l10n implications, since we need the need to scrap the facebook and twitter strings from their API so as to not ask localizers to retranslate it, not sure I will have time to work on that before next week, MozCamp Europe is starting tomorrow and I have several other projects requiring attention.
(Reporter)

Comment 2

7 years ago
(In reply to Pascal Chevrel:pascalc from comment #1)
> yes, this has l10n implications, since we need the need to scrap the
> facebook and twitter strings from their API so as to not ask localizers to
> retranslate it, not sure I will have time to work on that before next week,
> MozCamp Europe is starting tomorrow and I have several other projects
> requiring attention.

I think it's alright to work on this next week. Thanks!
Could we do something like the Affiliates page:

https://affiliates.mozilla.org/en-US/

There, the Twitter/Facebook links are just that, links, with real text:

"Share on Twitter" and "Share on Facebook"

This would get around having to find or make translated "[F] Share" and "[t] Tweet" buttons.

Pascal, are the "Share on Twitter" and "Share on Facebook" strings translated for any other project already?
(Assignee)

Comment 4

7 years ago
I am not sure we have those strings, but why not mimick the twitter and facebook buttons and just hard code (copy/paste them) the official translations of the strings that we currently get from the calls to their APIs ?

Comment 5

7 years ago
What if we just have icons and no text? It is generally understood that those are share buttons.
(In reply to Pascal Chevrel:pascalc from comment #4)
> I am not sure we have those strings, but why not mimick the twitter and
> facebook buttons and just hard code (copy/paste them) the official
> translations of the strings that we currently get from the calls to their
> APIs ?

We're probably fine for twitter. They don't seem to change their "tweet" button per locale.

For Facebook, though, we can't do a "Like" button without their embedded widget. We'll have to fall back on the deprecated "Share" method. Their Share widget didn't return a translated label.

(In reply to Chris More [:cmore] from comment #5)
> What if we just have icons and no text? It is generally understood that
> those are share buttons.
That would technically work, yes. The buttons could also have the site title with the icon, as "Twitter" and "Facebook" are proper nouns that aren't translated (right?).
(Assignee)

Comment 7

7 years ago
(In reply to Steven Garrity from comment #6)
> We're probably fine for twitter. They don't seem to change their "tweet"
> button per locale.

They do, for example 'twitter' in French or 'Twittern' in German.

> 
> For Facebook, though, we can't do a "Like" button without their embedded
> widget. We'll have to fall back on the deprecated "Share" method. Their
> Share widget didn't return a translated label.

We can add this string to the list of strings to translate for this project for localizers.
> 
> (In reply to Chris More [:cmore] from comment #5)
> > What if we just have icons and no text? It is generally understood that
> > those are share buttons.
> That would technically work, yes. The buttons could also have the site title
> with the icon, as "Twitter" and "Facebook" are proper nouns that aren't
> translated (right?).

Yes, those are untranslated brand names, we can do that.
This is done in trunk for en-US.
Keywords: qawanted
Whiteboard: r=98005, b=trunk
Target Milestone: --- → 4.7
(Reporter)

Comment 9

7 years ago
(In reply to Steven Garrity from comment #8)
> This is done in trunk for en-US.

Thanks Steven!

When clicking on a share link now, it redirects the user to the share dialog in the entire tab and the layout is very spread out. Could you have it open the share dialog in a new smaller window? That way the user never has to leave the main page and can still watch the video feed.

Steven, have the WebTrends click tracking snippets been added to the social links?
(Reporter)

Comment 10

7 years ago
Created attachment 576361 [details]
Share dialog window size example

Here's how the share dialog should appear in a new window. Twitter is shown as an example.
Assignee: steven → pascalc
Fixed the dialog size (r98035 in trunk). Thanks to twitter for a solid set of API/intent docs.
Whiteboard: r=98005, b=trunk → r=98005,98035 b=trunk
qa-verified-trunk on https://www-dev.allizom.org/firefoxlive, with Firefox 4+, Google Chrome (latest), IE 9, and Opera 11.52.
Keywords: qawanted → push-needed
(Assignee)

Comment 13

7 years ago
on production in r98223.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Keywords: push-needed
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.