Closed
Bug 701516
Opened 13 years ago
Closed 13 years ago
use httpd module to start running test-request.js tests again
Categories
(Add-on SDK Graveyard :: General, defect)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: myk, Assigned: KWierso)
References
Details
Attachments
(1 file)
A bunch of tests in test-request.js are commented out because they require a network connection. Now that we have the httpd module, we should use it to provide a local server for those tests so we can start running them again.
Assignee | ||
Comment 2•13 years ago
|
||
Here's about half of the request tests turned back on and adjusted to use the new httpd server module. The remaining tests require the original php files from Zpao's webserver, so I'm waiting for those before going any further.
Attachment #573700 -
Flags: review?(myk)
Reporter | ||
Comment 3•13 years ago
|
||
Comment on attachment 573700 [details]
Link to pull request 259
A few issues, a few nits, all noted in the pull request.
Attachment #573700 -
Flags: review?(myk) → review-
Assignee | ||
Comment 4•13 years ago
|
||
Comment on attachment 573700 [details]
Link to pull request 259
Comments addressed; re-requesting review.
Attachment #573700 -
Flags: review- → review?(myk)
Comment 5•13 years ago
|
||
Commit pushed to https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/a138a8085b8f8f585d497967fed08ccc66ccf3ed Merge pull request #259 from KWierso/test-requests fix bug 701516 - Use httpd module to serve files for newly re-enabled request tests. r=@mykmelez
Updated•13 years ago
|
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Reporter | ||
Updated•13 years ago
|
Attachment #573700 -
Flags: review?(myk) → review+
You need to log in
before you can comment on or make changes to this bug.
Description
•