use httpd module to start running test-request.js tests again

RESOLVED FIXED

Status

Add-on SDK
General
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: myk, Assigned: KWierso)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
A bunch of tests in test-request.js are commented out because they require a network connection.  Now that we have the httpd module, we should use it to provide a local server for those tests so we can start running them again.
(Assignee)

Comment 1

7 years ago
I can work on this tomorrow.
Assignee: nobody → kwierso
(Assignee)

Comment 2

7 years ago
Created attachment 573700 [details]
Link to pull request 259

Here's about half of the request tests turned back on and adjusted to use the new httpd server module.

The remaining tests require the original php files from Zpao's webserver, so I'm waiting for those before going any further.
Attachment #573700 - Flags: review?(myk)
(Reporter)

Comment 3

7 years ago
Comment on attachment 573700 [details]
Link to pull request 259

A few issues, a few nits, all noted in the pull request.
Attachment #573700 - Flags: review?(myk) → review-
(Assignee)

Comment 4

7 years ago
Comment on attachment 573700 [details]
Link to pull request 259

Comments addressed; re-requesting review.
Attachment #573700 - Flags: review- → review?(myk)

Comment 5

7 years ago
Commit pushed to https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/a138a8085b8f8f585d497967fed08ccc66ccf3ed
Merge pull request #259 from KWierso/test-requests

fix bug 701516 - Use httpd module to serve files for newly re-enabled request tests. r=@mykmelez

Updated

7 years ago
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Reporter)

Updated

7 years ago
Attachment #573700 - Flags: review?(myk) → review+
(Assignee)

Updated

7 years ago
Blocks: 703108
You need to log in before you can comment on or make changes to this bug.