701593 - Clicking the purchase button from the hovercard opens the Paypal link in a new tab

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P3)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Load https://addons-dev.allizom.org/en-US/apps/app/test-webapp-15/
2. Click on the purchase button in the hovercard for the app "BeeWalker" listed under 'Other apps by' section. 

expected behavior:

actual behavior:
The paypal link opens in a new tab instead of opening in a lightbox.

screencast: http://screencast.com/t/6edhiULM

Comment 1

[Gregory Koberger (:gkoberger)]

I can't reproduce this. Why is PayPal even being opened? You should get the AMO modal first. Did you authorize PayPal to charge you without having to go through all of the PayPal UI? (I forget the exact label for the option.)

Bumping since I can't reproduce it.

Comment 2

[Andy McKay]

The link in the new tab occurs when JS hasn't loaded or blown up for some reason. The href on the button points to the paypal purchase page. That's the fallback in case things go wrong.

Comment 3

[Gregory Koberger (:gkoberger)]

https://github.com/mozilla/zamboni/commit/707a68195cf2c33e65fdec0293ad47fea73c5220

This will still happen if you manage to beat the JavaScript, however a) I don't think anyone with a reasonably fast connection is fast enough for that and b) I have a patch for that, too.