701598 - Image conversion error when installing apps natively using Firefox less than 9 on Windows 7 and Vista

Status: VERIFIED WONTFIX

(Web Apps :: Extension, defect)

Description

[Mohamed Dabbagh]

Build identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0) Gecko/20100101 Firefox/8.0

When installing apps natively on Windows 7 or Vista using a release version of Firefox (tried with FF 7.0.1 and 8), an image conversion error is thrown. The app is still installed but the icon does not show up correctly (blank). I can still launch the app as well. I'm not including XP because there is currently a problem that doesn't allow us to install apps at all natively which will be fixed soon. I'm assuming that this problem occurs there as well.

Steps to Reproduce:
1. Install the addon-sdk (currently, must be from github) - https://github.com/mozilla/addon-sdk
2. Install the oauthorizer package (from github) into the packages folder of the addon-sdk folder - https://github.com/mozilla/oauthorizer
3. Clone the openwebapps project (from github) - https://github.com/mozilla/openwebapps
4. Checkout the feature/native-app branch
5. In a terminal, cd into addon-sdk 
6. Type: 'bin\activate'
7. cd into openwebapps\addons\jetpack
8. Type: cfx run (make sure to have a release version of FF installed)
9. Go to apps.mozillalabs.com/appdir (in the newly opened FF window)
10. Install an app

Actual Results:
An error is thrown when installing an app. The app is still installed and can be launched but the icon appears blank (app should have an icon on the desktop). The error is shown below.

Expected Results:
The app is installed successfully on the user's machine and the correct icon is displayed for the app.

Error:
info: APPS | nativeshell.win | synthesizeIcon - Failure converting icon http://tubagames.net/barfight/images/webappicon_128.png ([Exception... "Component returned failure code: 0x80540009 [imgITools.encodeImage]"  nsresult: "0x80540009 (<unknown>)"  location: "JS frame :: resource://openwebapps-at-mozillalabs-dot-com-api-utils-lib/cuddlefish.js -> resource://openwebapps-at-mozillalabs-dot-com-openwebapps-lib/nativeshell.js :: <TOP_LEVEL> :: line 720"  data: no]) d

Comment 1

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Image conversion was added to FF9 so icons won't be available in versions prior to that

Comment 2

[Mohamed Dabbagh]

Maybe we should place some documentation/release notes somewhere telling the user that native app installation only works with FF9 and above?

Comment 3

[Mohamed Dabbagh]

Closing as per Tim's comment #1. The user has to have Firefox 9 and above in order to get icons properly on native install.