701610 - Cannot install apps natively on Windows XP/Vista/7

Status: VERIFIED FIXED

(Web Apps :: Extension, defect, P1)

Description

[Mohamed Dabbagh]

When trying to install an app natively on Windows XP, an error is thrown and the installation fails. I believe it's because %LOCALAPPDATA% is not found in XP. Tim A. knows about this and is changing the location of the installation to be %APPDATA%. Will re-test once this change is committed.

Steps to reproduce:
1. Install the addon-sdk (currently, must be from github) - https://github.com/mozilla/addon-sdk
2. Install the oauthorizer package (from github) into the packages folder of the addon-sdk folder - https://github.com/mozilla/oauthorizer
3. Clone the openwebapps project (from github) - https://github.com/mozilla/openwebapps
4. Checkout the feature/native-app branch
5. In a terminal, cd into addon-sdk 
6. Type: 'bin\activate'
7. cd into openwebapps\addons\jetpack
8. Type: cfx --binary=<Path to Firefox nightly exe) - Known bug
9. Go to apps.mozillalabs.com/appdir (in the newly opened FF window)
10. Try to install an app

Actual Result:
An error is thrown and the app installation fails. 

Expected Result:
The app is installed successfully with no errors. 

Error:
APPS | NativeShell | Aborted: createExecutable - Failure setting up target location ([Exception... "Component returned failure code: 0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH) [nsILocalFile.initWithPath]"  nsresult: "0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH)"  location: "JS frame :: resource://openwebapps-at-mozillalabs-dot-com-api-utils-lib/cuddlefish.js -> resource://openwebapps-at-mozillalabs-dot-com-api-utils-lib/file.js :: MozFile :: line 62"  data: no])

Comment 1

[Mohamed Dabbagh]

Filed this to keep track of what needs to be verified once fixed.

Comment 2

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Mohamed, can you try this again with the latest code in feature/native-app?

Comment 3

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Are we still seeing this issue in XP?

Comment 4

[Mohamed Dabbagh]

Tested with an extension built from the feature/native-app branch. Installing apps on XP now works with no errors within the console. 

However the extension was built using 'cfx xpi' within the jetpack directory and not the usual recommended way of using 'make xpi' within the openwebapps folder. 

Also, the desktop icons do not show up but that's being tracked in Bug 702691. 

This bug should remain opened until the code merge into the 'develop' branch (or whatever branch is being used as the main/release branch) and re-tested with an xpi file built from there.

Comment 5

[Mohamed Dabbagh]

After the merge with the develop branch and retesting with an extension built from the 'develop' branch, native-app installation on XP is broken again. Below is the error thrown:

APPS | api.install.fetchManifest | Fetching manifest from http://www.limejs.com/
zlizer.webapp
APPS | api.install.fetchManifest | Got manifest (200) 546 bytes
APPS | api.install.displayPrompt | Checking for prompt
APPS | jetpack.install | Getting app by URL now

APPS | jetpack.install | getAppByUrl returned [object Object]

APPS | jetpack.install | Calling NativeShell.CreateNativeShell

APPS | NativeShell | Aborted: createExecutable - Failure running installer ([Exc
eption... "Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND)
 [nsIProcess.init]"  nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)"  location:
 "JS frame :: resource://openwebapps-at-mozillalabs-dot-com-api-utils-lib/cuddle
fish.js -> resource://openwebapps-at-mozillalabs-dot-com-openwebapps-lib/natives
hell.js :: <TOP_LEVEL> :: line 523"  data: no])

Comment 6

[Mohamed Dabbagh]

As per my comment #5, the same error is now thrown when installing apps on XP/Vista and 7. Only a folder with the app icon is installed within %APPDATA%.

Comment 7

[Mohamed Dabbagh]

Here's a link to the xpi file that I used http://people.mozilla.com/~dclarke/openwebapps/Extension/older/openwebapps-5f90c92fd4-11_23_2011.xpi

Comment 8

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Somehow the Windows installer disappeared in the merge.

This issue should be fixed by this change:
https://github.com/mozilla/openwebapps/commit/16b688bf71bb964817a569943bb56903871b209a

An XPI built from the current develop branch should see this issue disappear.

Comment 9

[Mohamed Dabbagh]

Tested on Windows 7 with extension openwebapps-9d582b6ddb-12_01_2011.xpi from http://people.mozilla.com/~dclarke/openwebapps/Extension/. Native app installation does not work. The icon gets created (blank) but then everything is removed as part of the failed installation clean-up.

Comment 10

[Mohamed Dabbagh]

Attachment: Screenshot

Screenshot of an error pop-up that appeared once while installing a native app on Windows 7.

Comment 11

[Mohamed Dabbagh]

Error thrown:

Traceback (most recent call last):
  File "C:\openwebapps\addons\jetpack\data\mgmtapi.js", line 46, in
TypeError: unsafeWindow.navigator.wrappedJSObject is undefined
info: APPS | NativeShell | Aborted: createExecutable - Failure copying files ([E
xception... "Component returned failure code: 0x80520001 (NS_ERROR_FILE_UNRECOGN
IZED_PATH) [nsILocalFile.append]"  nsresult: "0x80520001 (NS_ERROR_FILE_UNRECOGN
IZED_PATH)"  location: "JS frame :: resource://openwebapps-at-mozillalabs-dot-co
m-api-utils-lib/securable-module.js -> resource://openwebapps-at-mozillalabs-dot
-com-openwebapps-lib/nativeshell.js :: embedMozAppsAPIFiles :: line 233"  data:
no])

Comment 12

[Mohamed Dabbagh]

This has been fixed in the latest develop branch. I tested with openwebapps-23dc5022e9-12_02_2011.xpi found in http://people.mozilla.com/~dclarke/openwebapps/Extension/ on Windows XP, Vista and 7. We can now install apps natively on all three platforms.

Comment 13

[Mohamed Dabbagh]

Verified fixed as per my comment 12.