701613 - Add WinVista as supported OS in updater.exe.manifest

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Brian R. Bondy [:bbondy]]

The manifest only lists Vista as a supported OS but should also list Win7.  I don't think this will cause any problems but should have both listed.

rs originally found this for the maintenanceservice in a review, this is just applying that same fix to updater.exe.

Comment 1

[Brian R. Bondy [:bbondy]]

Attachment: Fixed manifest file

Comment 2

[Masatoshi Kimura [:emk]]

Currently listed only Win7, not WinVista.
And I doubt the usefulness of adding WinVista to SupportedOS because SupportedOS feature is added to the manifest when Win7 is released. WinVista will not recognize the SupportedOS anyway (at least before SP2).

Comment 3

[Brian R. Bondy [:bbondy]]

> Currently listed only Win7, not WinVista.

Thanks, my bad.

>  I doubt the usefulness

I don't think it matters either because we don't currently use what is listed here:
http://msdn.microsoft.com/en-us/library/dd371711%28v=vs.85%29.aspx

But I don't see any harm in adding it.

Comment 4

[Brian R. Bondy [:bbondy]]

I've had helper.exe's run in compatibility mode turn on on my machine for an unexplained reason. I read that it could be because of the parent program that executes it.  

I can't reliably reproduce anything but I'm going to land this anyway because it's the right thing to do.

Comment 5

[Brian R. Bondy [:bbondy]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/a0e9fba17816

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a0e9fba17816