Closed Bug 701664 Opened 11 years ago Closed 11 years ago

GCLI build should use the latest dryice build

Categories

(DevTools :: Console, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 11

People

(Reporter: jwalker, Assigned: jwalker)

References

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 file)

Version 0.3.0 fixed a bug where text! inclusions had newlines stripped and slashes mangled.
Upgrading to the latest inserts many \n into gcli.jsm, however the functionallity isn't changed.
Priority: -- → P1
Attached patch upload 1Splinter Review
2 changes
- insertion of \n
- s/void 0//g (i.e. implied undefined)
Attachment #575166 - Flags: review?(dcamp)
(In reply to Joe Walker from comment #1)

> - s/void 0//g (i.e. implied undefined)

I don't see that second change in this patch.
(In reply to Dave Camp (:dcamp) from comment #2)
> (In reply to Joe Walker from comment #1)
> 
> > - s/void 0//g (i.e. implied undefined)
> 
> I don't see that second change in this patch.

You're right - I was mis-reading the patch.
Moving GCLI bugs to Developer Tools: Console. Filter on 'baked beans are off'.
Component: Developer Tools → Developer Tools: Console
Comment on attachment 575166 [details] [diff] [review]
upload 1

Review of attachment 575166 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good as long as it's the patch you were looking to submit :)
Attachment #575166 - Flags: review?(dcamp) → review+
Depends on: 699411
Whiteboard: [land-in-fx-team]
Blocks: 699001
https://hg.mozilla.org/integration/fx-team/rev/0b44926dd34a
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/0b44926dd34a
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 11
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.