701664 - GCLI build should use the latest dryice build

Status: RESOLVED FIXED

(DevTools :: Console, defect, P1)

Description

[Joe Walker [:jwalker]]

Version 0.3.0 fixed a bug where text! inclusions had newlines stripped and slashes mangled.
Upgrading to the latest inserts many \n into gcli.jsm, however the functionallity isn't changed.

Comment 1

[Joe Walker [:jwalker]]

Attachment: upload 1

2 changes
- insertion of \n
- s/void 0//g (i.e. implied undefined)

Comment 2

[Dave Camp (:dcamp)]

(In reply to Joe Walker from comment #1)

> - s/void 0//g (i.e. implied undefined)

I don't see that second change in this patch.

Comment 3

[Joe Walker [:jwalker]]

(In reply to Dave Camp (:dcamp) from comment #2)
> (In reply to Joe Walker from comment #1)
> 
> > - s/void 0//g (i.e. implied undefined)
> 
> I don't see that second change in this patch.

You're right - I was mis-reading the patch.

Comment 4

[Joe Walker [:jwalker]]

https://tbpl.mozilla.org/?tree=Try&rev=47353dce1691

Comment 5

[Joe Walker [:jwalker]]

Moving GCLI bugs to Developer Tools: Console. Filter on 'baked beans are off'.

Comment 6

[Dave Camp (:dcamp)]

Comment on attachment 575166 [details] [diff] [review]
upload 1

Review of attachment 575166 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good as long as it's the patch you were looking to submit :)

Comment 7

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/integration/fx-team/rev/0b44926dd34a

Comment 8

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/mozilla-central/rev/0b44926dd34a