The default bug view has changed. See this FAQ.

Entity messengerWindow.title seems not to be used in Thunderbird

RESOLVED FIXED in Thunderbird 11.0

Status

Thunderbird
Mail Window Front End
--
trivial
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: AlexIhrig, Assigned: Nomis101)

Tracking

unspecified
Thunderbird 11.0
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
In messenger.dtd the first entity is:
<!ENTITY messengerWindow.title "Mail &amp; Newsgroups">

This entity seems not to be used in Thunderbird. So we could remove it.
(Assignee)

Comment 1

5 years ago
Created attachment 574065 [details] [diff] [review]
Patch

You are right. This one is only used from suite and suite has its own messenger.dtd
http://mxr.mozilla.org/comm-central/search?string=messengerWindow.title
It seems the corresponding line in TB messenger.xul was changed to title="&titledefault.label;@PRE_RELEASE_SUFFIX@" without editing the dtd file.
I've made a patch for that.
(Assignee)

Updated

5 years ago
Attachment #574065 - Flags: review?(bwinton)

Comment 2

5 years ago
While at it, is this line used in any way in Thunderbird:
mail/base/content/mailWindowOverlay.xul:
<menuitem hidden="true" accesskey="&messengerCmd.accesskey;" label="&messengerCmd.label;"
?
(In reply to :aceman from comment #2)
> While at it, is this line used in any way in Thunderbird:
> mail/base/content/mailWindowOverlay.xul:
> <menuitem hidden="true" accesskey="&messengerCmd.accesskey;"
> label="&messengerCmd.label;"
> ?

Perhaps not, although add-ons might use it for some reason or other.
Assignee: nobody → Nomis101
Status: NEW → ASSIGNED
Comment on attachment 574065 [details] [diff] [review]
Patch

Review of attachment 574065 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Thanks,
Blake.
Attachment #574065 - Flags: review?(bwinton) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Checked in: http://hg.mozilla.org/comm-central/rev/825d9b87e96c
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 11.0
You need to log in before you can comment on or make changes to this bug.