Closed Bug 701671 Opened 8 years ago Closed 8 years ago

Entity messengerWindow.title seems not to be used in Thunderbird

Categories

(Thunderbird :: Mail Window Front End, defect, trivial)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 11.0

People

(Reporter: bugzilla, Assigned: Nomis101)

Details

Attachments

(1 file)

In messenger.dtd the first entity is:
<!ENTITY messengerWindow.title "Mail &amp; Newsgroups">

This entity seems not to be used in Thunderbird. So we could remove it.
Attached patch PatchSplinter Review
You are right. This one is only used from suite and suite has its own messenger.dtd
http://mxr.mozilla.org/comm-central/search?string=messengerWindow.title
It seems the corresponding line in TB messenger.xul was changed to title="&titledefault.label;@PRE_RELEASE_SUFFIX@" without editing the dtd file.
I've made a patch for that.
Attachment #574065 - Flags: review?(bwinton)
While at it, is this line used in any way in Thunderbird:
mail/base/content/mailWindowOverlay.xul:
<menuitem hidden="true" accesskey="&messengerCmd.accesskey;" label="&messengerCmd.label;"
?
(In reply to :aceman from comment #2)
> While at it, is this line used in any way in Thunderbird:
> mail/base/content/mailWindowOverlay.xul:
> <menuitem hidden="true" accesskey="&messengerCmd.accesskey;"
> label="&messengerCmd.label;"
> ?

Perhaps not, although add-ons might use it for some reason or other.
Assignee: nobody → Nomis101
Status: NEW → ASSIGNED
Comment on attachment 574065 [details] [diff] [review]
Patch

Review of attachment 574065 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Thanks,
Blake.
Attachment #574065 - Flags: review?(bwinton) → review+
Keywords: checkin-needed
Checked in: http://hg.mozilla.org/comm-central/rev/825d9b87e96c
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 11.0
You need to log in before you can comment on or make changes to this bug.