Last Comment Bug 701671 - Entity messengerWindow.title seems not to be used in Thunderbird
: Entity messengerWindow.title seems not to be used in Thunderbird
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Mail Window Front End (show other bugs)
: unspecified
: All All
: -- trivial (vote)
: Thunderbird 11.0
Assigned To: Nomis101
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-11 04:54 PST by AlexIhrig
Modified: 2011-11-16 02:47 PST (History)
2 users (show)
standard8: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Patch (686 bytes, patch)
2011-11-12 08:43 PST, Nomis101
bwinton: review+
Details | Diff | Splinter Review

Description AlexIhrig 2011-11-11 04:54:30 PST
In messenger.dtd the first entity is:
<!ENTITY messengerWindow.title "Mail &amp; Newsgroups">

This entity seems not to be used in Thunderbird. So we could remove it.
Comment 1 Nomis101 2011-11-12 08:43:41 PST
Created attachment 574065 [details] [diff] [review]
Patch

You are right. This one is only used from suite and suite has its own messenger.dtd
http://mxr.mozilla.org/comm-central/search?string=messengerWindow.title
It seems the corresponding line in TB messenger.xul was changed to title="&titledefault.label;@PRE_RELEASE_SUFFIX@" without editing the dtd file.
I've made a patch for that.
Comment 2 :aceman 2011-11-12 09:40:12 PST
While at it, is this line used in any way in Thunderbird:
mail/base/content/mailWindowOverlay.xul:
<menuitem hidden="true" accesskey="&messengerCmd.accesskey;" label="&messengerCmd.label;"
?
Comment 3 Blake Winton (:bwinton) (:☕️) 2011-11-15 11:39:11 PST
(In reply to :aceman from comment #2)
> While at it, is this line used in any way in Thunderbird:
> mail/base/content/mailWindowOverlay.xul:
> <menuitem hidden="true" accesskey="&messengerCmd.accesskey;"
> label="&messengerCmd.label;"
> ?

Perhaps not, although add-ons might use it for some reason or other.
Comment 4 Blake Winton (:bwinton) (:☕️) 2011-11-15 11:40:28 PST
Comment on attachment 574065 [details] [diff] [review]
Patch

Review of attachment 574065 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Thanks,
Blake.
Comment 5 Mark Banner (:standard8, limited time in Dec) 2011-11-16 02:47:03 PST
Checked in: http://hg.mozilla.org/comm-central/rev/825d9b87e96c

Note You need to log in before you can comment on or make changes to this bug.