Closed
Bug 701723
Opened 14 years ago
Closed 14 years ago
deviceManager is a bad choice of variable name in bcontroller.py
Categories
(Testing :: Talos, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: wlach, Assigned: wlach)
Details
Attachments
(1 file)
|
4.20 KB,
patch
|
k0scist
:
review+
|
Details | Diff | Splinter Review |
In bcontroller.py we currently refer to the remote process class as "deviceManager", which is seriously misleading since it immediately makes you think that it's a device manager class, when in fact it's a RemoteProcess class (which consumes devicemanager).
I know bcontroller.py will be going away in the hopefully not-too-distant future, but in the interim I've already been bitten by this twice so I figured it was worth knocking up a trivial patch to change the variable name so it doesn't confuse anyone else.
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → wlachance
|
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #573815 -
Flags: review?(jhammel)
|
|
Assignee | |
Comment 2•14 years ago
|
||
(BTW, I already tested this locally and it works fine-- please feel free to push if you don't think the patch requires any revision)
|
||
Comment 3•14 years ago
|
||
Comment on attachment 573815 [details] [diff] [review]
Rename deviceManager -> remoteProcess
looks good to me
Attachment #573815 -
Flags: review?(jhammel) → review+
|
|
||
Comment 4•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•