Dragging attachments from the compose window doesn't work anymore

RESOLVED FIXED in Thunderbird 11.0

Status

Thunderbird
Message Compose Window
RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: squib, Assigned: squib)

Tracking

8 Branch
Thunderbird 11.0
Dependency tree / graph

Thunderbird Tracking Flags

(thunderbird9 fixed, thunderbird10 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Created attachment 574130 [details] [diff] [review]
Fix this

Bug 630759 broke this because I forgot to update a string in MsgComposeCommands.js. Here's the fix. I could write tests for this, but inter-window drag-and-drop tests are fairly complicated, so I'm going to avoid doing it unless specifically requested. :)
Attachment #574130 - Flags: review?(bwinton)
This patch does a lot more than just fixing the drag problem (lots of "renameAttachment" changes from bug 526998 in here as well)...
Not sure if such mixed patches are intended or desired?
OS: Linux → All
Hardware: x86_64 → All
Version: unspecified → 8
(Assignee)

Comment 2

6 years ago
Created attachment 574170 [details] [diff] [review]
Attach the right patch this time

Oops. The previous patch had some extra changes that stowed away.
Assignee: nobody → squibblyflabbetydoo
Attachment #574130 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #574130 - Flags: review?(bwinton)
Attachment #574170 - Flags: review?(bwinton)
Comment on attachment 574170 [details] [diff] [review]
Attach the right patch this time

Review of attachment 574170 [details] [diff] [review]:
-----------------------------------------------------------------

Seems to work for me.
Attachment #574170 - Flags: review?(bwinton) → review+
(Assignee)

Updated

6 years ago
Attachment #574170 - Flags: approval-comm-beta?
Attachment #574170 - Flags: approval-comm-aurora?
Duplicate of this bug: 702946
(Assignee)

Comment 5

6 years ago
Checked in: http://hg.mozilla.org/comm-central/rev/e4c895f1d759
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 11.0

Updated

6 years ago
Duplicate of this bug: 703528

Comment 7

6 years ago
(In reply to Jim Porter (:squib) from comment #5)
> Checked in: http://hg.mozilla.org/comm-central/rev/e4c895f1d759

How might I apply this patch to my local copy of Thunderbird? 

Thank you.
(In reply to Jim Porter (:squib) from comment #0)
> Bug 630759 broke this because I forgot to update a string in
> MsgComposeCommands.js. Here's the fix. I could write tests for this, but
> inter-window drag-and-drop tests are fairly complicated, so I'm going to
> avoid doing it unless specifically requested. :)

We should get some litmus tests then ;-)
Flags: in-litmus?(ludovic)
Attachment #574170 - Flags: approval-comm-beta?
Attachment #574170 - Flags: approval-comm-beta+
Attachment #574170 - Flags: approval-comm-aurora?
Attachment #574170 - Flags: approval-comm-aurora+
Checked into branches:

http://hg.mozilla.org/releases/comm-aurora/rev/91945160ae4f
http://hg.mozilla.org/releases/comm-beta/rev/08f96e424cd6
status-thunderbird10: --- → fixed
status-thunderbird9: --- → fixed
What was broken here ? dragging from one compose window to another ?
(Assignee)

Updated

6 years ago
Blocks: 304835
Flags: in-litmus?(ludovic)
You need to log in before you can comment on or make changes to this bug.