genericPhotoHandler saves wrong photoname

RESOLVED FIXED in Thunderbird 11.0

Status

Thunderbird
Address Book
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: Samuel Müller, Assigned: Samuel Müller)

Tracking

7 Branch
Thunderbird 11.0
x86_64
Windows 7

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0) Gecko/20100101 Firefox/8.0
Build ID: 20111104165243

Steps to reproduce:

the onSave method of onSave of genericPhotoHandler in abCardOverlay.js has the statement "aCard.setProperty("PhotoName", null);". this actually stores the string "null" in the card, which is wrong. the statemant should be "aCard.setProperty("PhotoName", "");". additionally it should also clear the photoURI: "aCard.setProperty("PhotoName", null);"
(Assignee)

Comment 1

6 years ago
Created attachment 574168 [details] [diff] [review]
patch fixing the problem

Updated

6 years ago
Assignee: nobody → samuel.mueller
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

Comment 2

6 years ago
Comment on attachment 574168 [details] [diff] [review]
patch fixing the problem

Requesting review on your behalf (you can do that yourself if a follow-up patch should be necessary).
Attachment #574168 - Flags: review?(mbanner)
Attachment #574168 - Flags: review?(mbanner) → review?(mconley)
Comment on attachment 574168 [details] [diff] [review]
patch fixing the problem

Looks good to me.
Attachment #574168 - Flags: review?(mconley) → review+

Comment 4

6 years ago
Thanks Mike.

Samuel, assuming that this doesn't need any further reviews, you can now set "checkin-needed" in the "Keywords" field, then someone will push it on the comm-central repository and your fix will show up in the trunk nightly builds.
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
Checked in: http://hg.mozilla.org/comm-central/rev/5fcf49d5c631
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 11.0

Updated

5 years ago
Blocks: 761852
You need to log in before you can comment on or make changes to this bug.