702137 - genericPhotoHandler saves wrong photoname

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[Samuel Müller]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0) Gecko/20100101 Firefox/8.0
Build ID: 20111104165243

Steps to reproduce:

the onSave method of onSave of genericPhotoHandler in abCardOverlay.js has the statement "aCard.setProperty("PhotoName", null);". this actually stores the string "null" in the card, which is wrong. the statemant should be "aCard.setProperty("PhotoName", "");". additionally it should also clear the photoURI: "aCard.setProperty("PhotoName", null);"

Comment 1

[Samuel Müller]

Attachment: patch fixing the problem

Comment 2

[rsx11m]

Comment on attachment 574168 [details] [diff] [review]
patch fixing the problem

Requesting review on your behalf (you can do that yourself if a follow-up patch should be necessary).

Comment 3

[Mike Conley (:mconley) (:⚙️) (PTO June 8 - 12)]

Comment on attachment 574168 [details] [diff] [review]
patch fixing the problem

Looks good to me.

Comment 4

[rsx11m]

Thanks Mike.

Samuel, assuming that this doesn't need any further reviews, you can now set "checkin-needed" in the "Keywords" field, then someone will push it on the comm-central repository and your fix will show up in the trunk nightly builds.

Comment 5

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/5fcf49d5c631