Closed
Bug 702137
Opened 13 years ago
Closed 13 years ago
genericPhotoHandler saves wrong photoname
Categories
(Thunderbird :: Address Book, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 11.0
People
(Reporter: samuel.mueller, Assigned: samuel.mueller)
References
Details
Attachments
(1 file)
|
816 bytes,
patch
|
mconley
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0) Gecko/20100101 Firefox/8.0
Build ID: 20111104165243
Steps to reproduce:
the onSave method of onSave of genericPhotoHandler in abCardOverlay.js has the statement "aCard.setProperty("PhotoName", null);". this actually stores the string "null" in the card, which is wrong. the statemant should be "aCard.setProperty("PhotoName", "");". additionally it should also clear the photoURI: "aCard.setProperty("PhotoName", null);"
|
Assignee | |
Comment 1•13 years ago
|
||
Assignee: nobody → samuel.mueller
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Comment on attachment 574168 [details] [diff] [review] patch fixing the problem Requesting review on your behalf (you can do that yourself if a follow-up patch should be necessary).
Attachment #574168 -
Flags: review?(mbanner)
|
||
Updated•13 years ago
|
Attachment #574168 -
Flags: review?(mbanner) → review?(mconley)
|
||
Comment 3•13 years ago
|
||
Comment on attachment 574168 [details] [diff] [review] patch fixing the problem Looks good to me.
Attachment #574168 -
Flags: review?(mconley) → review+
Thanks Mike. Samuel, assuming that this doesn't need any further reviews, you can now set "checkin-needed" in the "Keywords" field, then someone will push it on the comm-central repository and your fix will show up in the trunk nightly builds.
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
|
||
Comment 5•13 years ago
|
||
Checked in: http://hg.mozilla.org/comm-central/rev/5fcf49d5c631
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 11.0
You need to log in
before you can comment on or make changes to this bug.
Description
•