Last Comment Bug 702137 - genericPhotoHandler saves wrong photoname
: genericPhotoHandler saves wrong photoname
Product: Thunderbird
Classification: Client Software
Component: Address Book (show other bugs)
: 7 Branch
: x86_64 Windows 7
-- normal (vote)
: Thunderbird 11.0
Assigned To: Samuel Müller
Depends on:
Blocks: 761852
  Show dependency treegraph
Reported: 2011-11-13 11:16 PST by Samuel Müller
Modified: 2012-06-05 16:40 PDT (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

patch fixing the problem (816 bytes, patch)
2011-11-13 11:26 PST, Samuel Müller
mconley: review+
Details | Diff | Splinter Review

Description User image Samuel Müller 2011-11-13 11:16:19 PST
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0) Gecko/20100101 Firefox/8.0
Build ID: 20111104165243

Steps to reproduce:

the onSave method of onSave of genericPhotoHandler in abCardOverlay.js has the statement "aCard.setProperty("PhotoName", null);". this actually stores the string "null" in the card, which is wrong. the statemant should be "aCard.setProperty("PhotoName", "");". additionally it should also clear the photoURI: "aCard.setProperty("PhotoName", null);"
Comment 1 User image Samuel Müller 2011-11-13 11:26:10 PST
Created attachment 574168 [details] [diff] [review]
patch fixing the problem
Comment 2 User image rsx11m 2011-11-14 08:41:09 PST
Comment on attachment 574168 [details] [diff] [review]
patch fixing the problem

Requesting review on your behalf (you can do that yourself if a follow-up patch should be necessary).
Comment 3 User image Mike Conley (:mconley) 2011-11-14 12:08:28 PST
Comment on attachment 574168 [details] [diff] [review]
patch fixing the problem

Looks good to me.
Comment 4 User image rsx11m 2011-11-14 12:46:01 PST
Thanks Mike.

Samuel, assuming that this doesn't need any further reviews, you can now set "checkin-needed" in the "Keywords" field, then someone will push it on the comm-central repository and your fix will show up in the trunk nightly builds.
Comment 5 User image Mark Banner (:standard8) 2011-11-16 02:46:43 PST
Checked in:

Note You need to log in before you can comment on or make changes to this bug.