702216 - Menu > Quit doesn't close Fennec

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Cristian Nicolae (:xti)]

Mozilla/5.0 (Android;Linux armv7l;rv:10.0a1)Gecko/20111113
Firefox/10.0a1 Fennec/10.0a1
Devices: Motorola Droid 2
OS: Android 2.3.3

Steps to reproduce:
1. Open Fennec app
2. Tap on device Menu button
3. Tap on More > Quit

Expected result:
After step 3, the app is closed and the Fennec process will be stopped.

Actual result:
After step 3, nothing happens. The app menu triggered at step 2 still remains displayed on the screen.

Comment 1

[Aaron Train [:aaronmt]]

Seems like http://hg.mozilla.org/projects/birch/rev/0bbca97a14ad from bug 699442 didn't fix this.

Comment 2

[Doug Turner (:dougt)]

Attachment: patch v.1

Android apps don't typically have a Quit menu.  Remove it, and close all of the bugs related to "quit not working right"

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Note, atm there is no way to close Native Fennec. The Back button doesn't do it, like it does
in the stock browser. (I'm not sure if Back button just hides stock browser)

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 574699 [details] [diff] [review]
patch v.1

Review of attachment 574699 [details] [diff] [review]:
-----------------------------------------------------------------

remove the "Browser:Quit" handler in browser.js and the image from drawables

Comment 5

[Doug Turner (:dougt)]

Attachment: patch v.2

no drawables for quit.

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 574993 [details] [diff] [review]
patch v.2

Review of attachment 574993 [details] [diff] [review]:
-----------------------------------------------------------------

looking at this patch, I realize why quit isn't working and its because the logic that handles it got bashed by one of mfinkle's pushes (http://hg.mozilla.org/projects/birch/rev/043d1443dbc2).

Our justification for removing this is "we just can't get it to work right," which doesn't seem to hold water. Let's fix mfinkle's push and get this feature back in.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

(In reply to Brad Lassey [:blassey] from comment #6)
> Let's fix mfinkle's push and get this
> feature back in.
Thank you.

Comment 8

[Brad Lassey [:blassey] (use needinfo?)]

pushed https://hg.mozilla.org/projects/birch/rev/75c427dc76f9

Comment 9

[Aaron Train [:aaronmt]]

Samsung Nexus S (Android 2.3.6)
20111117040329
http://hg.mozilla.org/projects/birch/rev/d7fa4814218d