Closed
Bug 702216
Opened 11 years ago
Closed 11 years ago
Menu > Quit doesn't close Fennec
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: xti, Assigned: blassey)
References
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
4.55 KB,
patch
|
blassey
:
review-
|
Details | Diff | Splinter Review |
Mozilla/5.0 (Android;Linux armv7l;rv:10.0a1)Gecko/20111113 Firefox/10.0a1 Fennec/10.0a1 Devices: Motorola Droid 2 OS: Android 2.3.3 Steps to reproduce: 1. Open Fennec app 2. Tap on device Menu button 3. Tap on More > Quit Expected result: After step 3, the app is closed and the Fennec process will be stopped. Actual result: After step 3, nothing happens. The app menu triggered at step 2 still remains displayed on the screen.
Comment 1•11 years ago
|
||
Seems like http://hg.mozilla.org/projects/birch/rev/0bbca97a14ad from bug 699442 didn't fix this.
Blocks: 699442
Updated•11 years ago
|
Keywords: regression
Updated•11 years ago
|
Assignee: nobody → doug.turner
Comment 2•11 years ago
|
||
Android apps don't typically have a Quit menu. Remove it, and close all of the bugs related to "quit not working right"
Comment 3•11 years ago
|
||
Note, atm there is no way to close Native Fennec. The Back button doesn't do it, like it does in the stock browser. (I'm not sure if Back button just hides stock browser)
Updated•11 years ago
|
Attachment #574699 -
Flags: review?(blassey.bugs)
Assignee | ||
Comment 4•11 years ago
|
||
Comment on attachment 574699 [details] [diff] [review] patch v.1 Review of attachment 574699 [details] [diff] [review]: ----------------------------------------------------------------- remove the "Browser:Quit" handler in browser.js and the image from drawables
Attachment #574699 -
Flags: review?(blassey.bugs) → review-
Comment 5•11 years ago
|
||
no drawables for quit.
Attachment #574699 -
Attachment is obsolete: true
Attachment #574993 -
Flags: review?(blassey.bugs)
Assignee | ||
Comment 6•11 years ago
|
||
Comment on attachment 574993 [details] [diff] [review] patch v.2 Review of attachment 574993 [details] [diff] [review]: ----------------------------------------------------------------- looking at this patch, I realize why quit isn't working and its because the logic that handles it got bashed by one of mfinkle's pushes (http://hg.mozilla.org/projects/birch/rev/043d1443dbc2). Our justification for removing this is "we just can't get it to work right," which doesn't seem to hold water. Let's fix mfinkle's push and get this feature back in.
Attachment #574993 -
Flags: review?(blassey.bugs) → review-
Updated•11 years ago
|
Assignee: doug.turner → blassey.bugs
Comment 7•11 years ago
|
||
(In reply to Brad Lassey [:blassey] from comment #6) > Let's fix mfinkle's push and get this > feature back in. Thank you.
Assignee | ||
Comment 8•11 years ago
|
||
pushed https://hg.mozilla.org/projects/birch/rev/75c427dc76f9
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 9•11 years ago
|
||
Samsung Nexus S (Android 2.3.6) 20111117040329 http://hg.mozilla.org/projects/birch/rev/d7fa4814218d
Status: RESOLVED → VERIFIED
Updated•1 year ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•