nsXMLHttpRequest::GetResponse duplicates quickstub code

RESOLVED FIXED in mozilla11

Status

()

Core
DOM
RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla11
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 574266 [details] [diff] [review]
Patch v1

Except it doesn't handle the case where XPCStringConvert::ReadableToJSVal returns null.
Attachment #574266 - Flags: review?(bzbarsky)
Is it correct including XPCQuickStubs.h outside the quickstub?

Comment 2

6 years ago
xpc_qsStringToJsval is used elsewhere already, and I don't see any reasons why not use it in XHR.
Although xpcprivate.h is already used outside the xpconnect, there exists bug 691463.
(Assignee)

Comment 4

6 years ago
Yep, and that bug is the reason I was checking if XHR needed to use XPCConvert.
Comment on attachment 574266 [details] [diff] [review]
Patch v1

r=me.  Yay code removal.
Attachment #574266 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 6

6 years ago
https://hg.mozilla.org/mozilla-central/rev/178a3e2dc3f0
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
(Assignee)

Updated

6 years ago
Whiteboard: [qa-]
Component: DOM: Mozilla Extensions → DOM
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.