Except it doesn't handle the case where XPCStringConvert::ReadableToJSVal returns null.
Attachment #574266 - Flags: review?(bzbarsky)
Is it correct including XPCQuickStubs.h outside the quickstub?
xpc_qsStringToJsval is used elsewhere already, and I don't see any reasons why not use it in XHR.
Although xpcprivate.h is already used outside the xpconnect, there exists bug 691463.
Yep, and that bug is the reason I was checking if XHR needed to use XPCConvert.
Comment on attachment 574266 [details] [diff] [review] Patch v1 r=me. Yay code removal.
Attachment #574266 - Flags: review?(bzbarsky) → review+
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in before you can comment on or make changes to this bug.