Closed
Bug 702264
Opened 12 years ago
Closed 12 years ago
[ICS] - ActionBar above navigation bar
Categories
(Firefox for Android Graveyard :: General, defect, P4)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: aaronmt, Assigned: sriram)
Details
(Whiteboard: [ICS])
Attachments
(3 files)
30.20 KB,
image/png
|
Details | |
12.92 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
11.48 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
See screenshot. -- 20111114063828 http://hg.mozilla.org/projects/birch/rev/1c92e36629f5 Samsung Nexus S (Android 4.0)
Updated•12 years ago
|
Priority: -- → P4
Updated•12 years ago
|
Summary: [ICS] - Progress bar above navigation bar → [ICS] - ActionBar above navigation bar
Assignee | ||
Updated•12 years ago
|
Assignee: lucasr.at.mozilla → sriram
Comment 2•12 years ago
|
||
Also seen on Android 3.2.
Assignee | ||
Comment 3•12 years ago
|
||
This patch does the required cleanup in AndroidManifest to use common theme names (based off "Gecko" shadowing android themes) between Honeycomb+ and Gingerbread-. This way of using themes ensure that the AndroidManifest remains the same, while the themes change based on which OS version it is running. Also, this added a new styles.xml to use honeycomb specific styles. With this, the list in AwesomeBar uses native styling. AndroidManifest.xml was also cleared to just use the requires flags. Few activities had "MAIN" intent-filter with them -- which wasn't needed. Also, the activities like GeckoPreferences doesn't check for the "intent-filter" in them. Hence they have been removed.
Attachment #576551 -
Flags: review?(mark.finkle)
Assignee | ||
Comment 4•12 years ago
|
||
This patch adds "ActionBar" support to Honeycomb and ICS. They are basically handled in themes as much as possible. Using "displayOptions" with themes will be more elegant. However, they will fragment the themes so much for each activity. Hence they are handled during onCreate. I would be happy to revisit cleaning that part later if possible. I couldn't find any documentation that supports using "displayOptions" directly with the activity.
Attachment #576553 -
Flags: review?(mark.finkle)
Updated•12 years ago
|
Attachment #576553 -
Flags: review?(mark.finkle) → review+
Updated•12 years ago
|
Attachment #576551 -
Flags: review?(mark.finkle) → review+
Comment 5•12 years ago
|
||
https://hg.mozilla.org/projects/birch/rev/e65b90ceb471 https://hg.mozilla.org/projects/birch/rev/8ebd6300890a
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 6•11 years ago
|
||
Verified on Samsung Galaxy Nexus (Android 4.0.1). Nightly 12.0a1 (2012-01-16) Aurora 11.0a2 (2012-01-17)
Status: RESOLVED → VERIFIED
Updated•2 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•