Closed Bug 702275 Opened 8 years ago Closed 8 years ago

check AddObserver return code in nsDOMStorage.cpp

Categories

(Core :: DOM: Core & HTML, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla11

People

(Reporter: espindola, Assigned: espindola)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
https://tbpl.mozilla.org/?tree=Try&rev=a3dc6742a442
Assignee: nobody → respindola
Status: NEW → ASSIGNED
Attachment #574302 - Flags: review?(honzab.moz)
Attachment #574302 - Flags: feedback?(mak77)
Attachment #574302 - Attachment is obsolete: true
Attachment #574302 - Flags: review?(honzab.moz)
Attachment #574302 - Flags: feedback?(mak77)
Comment on attachment 574309 [details] [diff] [review]
check AddObserver return code in nsDOMStorage.cpp

Review of attachment 574309 [details] [diff] [review]:
-----------------------------------------------------------------

r=honzab, but depends on the try server run.
Attachment #574309 - Flags: review?(honzab.moz) → review+
https://hg.mozilla.org/mozilla-central/rev/56fc3f9f0187
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
Comment on attachment 574309 [details] [diff] [review]
check AddObserver return code in nsDOMStorage.cpp

Review of attachment 574309 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/src/storage/nsDOMStorage.cpp
@@ +287,5 @@
>    if (!os)
>      return NS_OK;
>  
> +  nsresult rv;
> +  rv = os->AddObserver(gStorageManager, "cookie-changed", false);

nit: we usually declare vars at first use, but whatever.
Attachment #574309 - Flags: feedback?(mak77) → feedback+
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.