Last Comment Bug 702275 - check AddObserver return code in nsDOMStorage.cpp
: check AddObserver return code in nsDOMStorage.cpp
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: unspecified
: x86_64 Linux
: -- normal (vote)
: mozilla11
Assigned To: Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
:
Mentors:
Depends on:
Blocks: 697988
  Show dependency treegraph
 
Reported: 2011-11-14 08:02 PST by Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
Modified: 2012-02-01 13:56 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
check AddObserver return code in nsDOMStorage.cpp (2.45 KB, patch)
2011-11-14 08:10 PST, Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
no flags Details | Diff | Splinter Review
check AddObserver return code in nsDOMStorage.cpp (2.45 KB, patch)
2011-11-14 08:26 PST, Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
honzab.moz: review+
mak77: feedback+
Details | Diff | Splinter Review

Description Rafael Ávila de Espíndola (:espindola) (not reading bugmail) 2011-11-14 08:02:07 PST

    
Comment 1 Rafael Ávila de Espíndola (:espindola) (not reading bugmail) 2011-11-14 08:10:23 PST
Created attachment 574302 [details] [diff] [review]
check AddObserver return code in nsDOMStorage.cpp

https://tbpl.mozilla.org/?tree=Try&rev=a3dc6742a442
Comment 2 Rafael Ávila de Espíndola (:espindola) (not reading bugmail) 2011-11-14 08:26:02 PST
Created attachment 574309 [details] [diff] [review]
check AddObserver return code in nsDOMStorage.cpp

https://tbpl.mozilla.org/?tree=Try&rev=8e0b21467e32
Comment 3 Honza Bambas (:mayhemer) 2011-11-14 08:55:19 PST
Comment on attachment 574309 [details] [diff] [review]
check AddObserver return code in nsDOMStorage.cpp

Review of attachment 574309 [details] [diff] [review]:
-----------------------------------------------------------------

r=honzab, but depends on the try server run.
Comment 4 Ed Morley [:emorley] 2011-11-15 11:50:19 PST
https://hg.mozilla.org/mozilla-central/rev/56fc3f9f0187
Comment 5 Marco Bonardo [::mak] 2011-11-16 07:36:24 PST
Comment on attachment 574309 [details] [diff] [review]
check AddObserver return code in nsDOMStorage.cpp

Review of attachment 574309 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/src/storage/nsDOMStorage.cpp
@@ +287,5 @@
>    if (!os)
>      return NS_OK;
>  
> +  nsresult rv;
> +  rv = os->AddObserver(gStorageManager, "cookie-changed", false);

nit: we usually declare vars at first use, but whatever.

Note You need to log in before you can comment on or make changes to this bug.