702275 - check AddObserver return code in nsDOMStorage.cpp

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: check AddObserver return code in nsDOMStorage.cpp

https://tbpl.mozilla.org/?tree=Try&rev=a3dc6742a442

Comment 2

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: check AddObserver return code in nsDOMStorage.cpp

https://tbpl.mozilla.org/?tree=Try&rev=8e0b21467e32

Comment 3

[Honza Bambas (:mayhemer)]

Comment on attachment 574309 [details] [diff] [review]
check AddObserver return code in nsDOMStorage.cpp

Review of attachment 574309 [details] [diff] [review]:
-----------------------------------------------------------------

r=honzab, but depends on the try server run.

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/56fc3f9f0187

Comment 5

[Marco Bonardo [:mak]]

Comment on attachment 574309 [details] [diff] [review]
check AddObserver return code in nsDOMStorage.cpp

Review of attachment 574309 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/src/storage/nsDOMStorage.cpp
@@ +287,5 @@
>    if (!os)
>      return NS_OK;
>  
> +  nsresult rv;
> +  rv = os->AddObserver(gStorageManager, "cookie-changed", false);

nit: we usually declare vars at first use, but whatever.