The default bug view has changed. See this FAQ.

check AddObserver return code in nsDOMStorage.cpp

RESOLVED FIXED in mozilla11

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: espindola, Assigned: espindola)

Tracking

unspecified
mozilla11
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
Blocks: 697988
Created attachment 574302 [details] [diff] [review]
check AddObserver return code in nsDOMStorage.cpp

https://tbpl.mozilla.org/?tree=Try&rev=a3dc6742a442
Assignee: nobody → respindola
Status: NEW → ASSIGNED
Attachment #574302 - Flags: review?(honzab.moz)
Attachment #574302 - Flags: feedback?(mak77)
Created attachment 574309 [details] [diff] [review]
check AddObserver return code in nsDOMStorage.cpp

https://tbpl.mozilla.org/?tree=Try&rev=8e0b21467e32
Attachment #574309 - Flags: review?(honzab.moz)
Attachment #574309 - Flags: feedback?(mak77)
Attachment #574302 - Attachment is obsolete: true
Attachment #574302 - Flags: review?(honzab.moz)
Attachment #574302 - Flags: feedback?(mak77)
Comment on attachment 574309 [details] [diff] [review]
check AddObserver return code in nsDOMStorage.cpp

Review of attachment 574309 [details] [diff] [review]:
-----------------------------------------------------------------

r=honzab, but depends on the try server run.
Attachment #574309 - Flags: review?(honzab.moz) → review+
https://hg.mozilla.org/mozilla-central/rev/56fc3f9f0187
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
Comment on attachment 574309 [details] [diff] [review]
check AddObserver return code in nsDOMStorage.cpp

Review of attachment 574309 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/src/storage/nsDOMStorage.cpp
@@ +287,5 @@
>    if (!os)
>      return NS_OK;
>  
> +  nsresult rv;
> +  rv = os->AddObserver(gStorageManager, "cookie-changed", false);

nit: we usually declare vars at first use, but whatever.
Attachment #574309 - Flags: feedback?(mak77) → feedback+
You need to log in before you can comment on or make changes to this bug.