702293 - AMO says my browser doesn't support web apps

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P1)

Description

[Wil Clouser [:clouserw]]

I'm running nightly and seeing "It seems your browser does not support Open Web Apps. Consider downloading Mozilla Firefox, a fast, free way to surf the Web!" in the header of apps-preview-dev.allizom.org:

> Mozilla/5.0 (X11; Linux i686; rv:10.0a1) Gecko/20111104 Firefox/10.0a1

Looks like the code is doing this:

>  'webApps': !!(navigator.mozApps && navigator.mozApps.install)

Are those endpoints in Firefox yet and my install is just broken, or do we need to have an add-on installed for this?  If we need an add-on I assume we need to change this message for the release on the 22nd?  Assigning to Davor but, Bill, can you tell us the current status of this stuff?

Comment 1

[Bill Walker [:bwalker] [@wfwalker]]

1. We should _always_ include https://myapps.mozillalabs.com/jsapi/include.js in every page that might have an app install button. I believe those implementations will get overridden by an Add-on or native implementation, but we should always be able to fall back on an HTML5-only implementation (this is also known as "Guest Mode").

2. I only want to see "your browser does not support Apps" if javascript is disabled and/or the browser does not support HTML5.

3. I never want to hear or read the phrase "Open Web Apps" again. User Research show that "Open Web Apps" universally implies "slow, crappy, and free". We should call them "Apps" or perhaps "HTML5 Apps".

Comment 2

[Davor Spasovski [:spasovski]]

Thanks for the points Bill. This bug will mostly be eliminated since we'll be including the mozilla labs include.js as part of the install buttons push but I'll need to change the message to remove "Open Web Apps"

As an aside I am not sure which FF version will support apps natively without requiring the include.js and am surprised the nightly doesn't.

Comment 3

[Bill Walker [:bwalker] [@wfwalker]]

Harald tells me there is some beginning support in Fennec nightly now; I'm not sure when / how it lands in Firefox desktop.

Comment 4

[Bill Walker [:bwalker] [@wfwalker]]

Davor: an update -- Andreas and Fabrice intend to land this stuff in FF12, assuming they can hit 12/20-ish deadline

Comment 5

[Potch [:potch]]

alright, this should be fixed now

https://github.com/mozilla/zamboni/commit/8c7a0f8

Comment 7

[krupa raj[:krupa]]

This is still happening. http://screencast.com/t/IkqMD76bUg7j

checked it at Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:8.0.1) Gecko/20100101 Firefox/8.0.1

Comment 8

[Christopher Van Wiemeersch [:cvan]]

(In reply to Bill Walker from comment #1)

> 2. I only want to see "your browser does not support Apps" if javascript is
> disabled and/or the browser does not support HTML5.

Showing this for users with JS disabled is doable, but what classifies a browser as not supporting HTML5?

Comment 9

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/1ae746d