Recently Closed Tabs/Windows in the Go menu are no longer disabled when empty

RESOLVED FIXED in seamonkey2.8

Status

SeaMonkey
Bookmarks & History
--
minor
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: rsx11m, Assigned: ewong)

Tracking

({regression})

Trunk
seamonkey2.8
regression

SeaMonkey Tracking Flags

(seamonkey2.5 wontfix, seamonkey2.6- wontfix, seamonkey2.7+ fixed, seamonkey2.8 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

6 years ago
At least since the 2011-10-31 nightly trunk build, the Recently Closed Tabs and Recently Closed Windows menu items remain available even if those lists are empty. Only an empty submenu shows up when selected, no Error Console messages.
(Reporter)

Comment 1

6 years ago
I'm seeing this in 2.5 beta 4 already, both on Windows 7 and - to a lesser extent (menu items enabled but no empty submenu) - on Linux as well.

Maybe that's what Neil was referring to in bug 599731 comment #14?

> The code to enable and disable the menus was unfortunately hidden away at
> the end of updateCloseItems. This needs to be moved into a new function so
> that it can be called from the go popup.
status-seamonkey2.5: --- → affected
status-seamonkey2.6: --- → affected
OS: Windows 7 → All
Hardware: x86_64 → All
(Reporter)

Comment 2

6 years ago
Bug 599731 was pushed Tue Jul 12 06:52:48 2011 -0700; the 20110710 Windows comm-central build does not exhibit the problem whereas the 20110713 build does. Thus, it seems that this bug is indeed the cause of the regression but apparently was neither resolved in bug 675672 nor filed as a separate follow-up bug (which is this one here now).

Further information from Ian in bug 599731 comment #15:
> The relevant code to be moved starts at
> http://mxr.mozilla.org/comm-central/source/suite/browser/navigator.js#1500
> You will need to add a onpopupshowing to the "history-menu"
> http://mxr.mozilla.org/comm-central/source/suite/browser/navigatorOverlay.xul#380
Blocks: 599731
Component: UI Design → Bookmarks & History
Keywords: regressionwindow-wanted
QA Contact: ui-design → bookmarks
(Assignee)

Updated

6 years ago
Assignee: nobody → ewong
Status: NEW → ASSIGNED
(Assignee)

Comment 3

6 years ago
Created attachment 574801 [details] [diff] [review]
Disable Recently Closed Tabs/Windows in the Go Menu when empty.
Attachment #574801 - Flags: review?(iann_bugzilla)
This is now listed as a Known Issue starting with SM 2.5. Please try to get Aurora/Beta approval once you have r+.
status-seamonkey2.8: --- → affected
tracking-seamonkey2.6: --- → ?
tracking-seamonkey2.7: --- → ?
Keywords: relnote

Comment 5

6 years ago
Comment on attachment 574801 [details] [diff] [review]
Disable Recently Closed Tabs/Windows in the Go Menu when empty.

>+function updateRecentMenuItems()
>+{
>+  var browser = getBrowser();
>+  var ss = Components.classes["@mozilla.org/suite/sessionstore;1"]
>+                     .getService(Components.interfaces.nsISessionStore);
You've added the sessionstore service here, but not removed it from earlier in updateCloseItems function.

r- for the moment
Attachment #574801 - Flags: review?(iann_bugzilla) → review-
(Assignee)

Comment 6

6 years ago
Created attachment 576730 [details] [diff] [review]
Disable Recently Closed Tabs/Windows in the Go menu when empty. (v2)
Attachment #574801 - Attachment is obsolete: true
Attachment #576730 - Flags: review?(iann_bugzilla)

Updated

6 years ago
Attachment #576730 - Flags: review?(iann_bugzilla) → review+
(Assignee)

Comment 7

6 years ago
Pushed to http://hg.mozilla.org/comm-central/rev/1d4e052858df.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
status-seamonkey2.8: affected → fixed
Target Milestone: --- → seamonkey2.8

Comment 8

6 years ago
Comment on attachment 576730 [details] [diff] [review]
Disable Recently Closed Tabs/Windows in the Go menu when empty. (v2)

> function updateCloseItems()
...
>+  updateRecentMenuItems();
Probably didn't need to do this here, just calling it from the Go menu suffices.
(Reporter)

Comment 9

6 years ago
I don't know what the cutoff for 2.6 is, but are you going to request approval-aurora/beta, with or without the change Neil suggested in comment #8?
(Assignee)

Updated

6 years ago
Attachment #576730 - Flags: approval-comm-beta?
Attachment #576730 - Flags: approval-comm-aurora?
(Assignee)

Comment 10

6 years ago
Created attachment 579986 [details] [diff] [review]
Removed unneccessary code from original patch.

v2 of the patch introduced a superfluous line.  This patch removes it and
the blank line.
Attachment #579986 - Flags: review?(neil)

Updated

6 years ago
Attachment #579986 - Flags: review?(neil) → review+
Edmund, can you please push the second patch to c-c.

IanN can you please evaluate the risk of both of these patches going into aurora and beta and handle approvals respectively?

(Code freeze for 2.6 is late monday)
tracking-seamonkey2.6: ? → +
tracking-seamonkey2.7: ? → +
(Assignee)

Comment 12

6 years ago
Pushed to comm-central: 
http://hg.mozilla.org/comm-central/rev/64a900fced07
Comment on attachment 576730 [details] [diff] [review]
Disable Recently Closed Tabs/Windows in the Go menu when empty. (v2)

Not sure how we missed this for 2.6 cycle, sorry. But we should take this for 2.7
Attachment #576730 - Flags: approval-comm-beta?
Attachment #576730 - Flags: approval-comm-beta+
Attachment #576730 - Flags: approval-comm-aurora?
Attachment #576730 - Flags: approval-comm-aurora-

Updated

6 years ago
tracking-seamonkey2.6: + → -
status-seamonkey2.5: affected → wontfix
status-seamonkey2.6: affected → wontfix

Updated

6 years ago
Keywords: checkin-needed
Whiteboard: c-n for comm-beta
Comment on attachment 576730 [details] [diff] [review]
Disable Recently Closed Tabs/Windows in the Go menu when empty. (v2)

http://hg.mozilla.org/releases/comm-beta/rev/1430d8e9f084
Comment on attachment 579986 [details] [diff] [review]
Removed unneccessary code from original patch.

http://hg.mozilla.org/releases/comm-beta/rev/7acacf881840
status-seamonkey2.7: affected → fixed
Keywords: checkin-needed
Whiteboard: c-n for comm-beta
Keywords: relnote
You need to log in before you can comment on or make changes to this bug.