Closed Bug 702341 Opened 8 years ago Closed 8 years ago

Flash plugins don't respond to panning/zooming changes

Categories

(Firefox for Android :: General, defect, P1)

ARM
Android
defect

Tracking

()

VERIFIED FIXED
Tracking Status
firefox11 --- verified
fennec 11+ ---

People

(Reporter: snorp, Assigned: snorp)

Details

Attachments

(1 file, 3 obsolete files)

The plugin window is currently positioned and sized according to what Gecko thinks. The current panning/zooming code is all in the higher Java layers, so that information never gets back down to Gecko. We need to solve this either by actually scaling/scrolling the content or mucking with the plugin SurfaceViews directly. It seems like some combination of the two could work best.
Attachment #574338 - Attachment is obsolete: true
Attachment #574349 - Flags: review?(blassey.bugs)
Priority: -- → P1
Comment on attachment 574349 [details] [diff] [review]
Add a hack to make plugins (mostly) positioned correctly [

Review of attachment 574349 [details] [diff] [review]:
-----------------------------------------------------------------

::: embedding/android/GeckoApp.java
@@ +1729,5 @@
> +    {
> +        public int originalX;
> +        public int originalY;
> +
> +        public PluginLayoutParams(int width, int height, int x, int y) {

use aX and aY to avoid confusion with x and y member variables
Attachment #574349 - Flags: review?(blassey.bugs) → review+
Attachment #574349 - Attachment is obsolete: true
Attachment #574483 - Attachment is obsolete: true
Attachment #574484 - Flags: review?(blassey.bugs) → review+
https://hg.mozilla.org/projects/birch/rev/b2957d1980e6
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
tracking-fennec: --- → 11+
Verified on Native Nightly 13.0a1 (2012-02-15)
            Native Beta 11.0 (20120215185359)
Device: Samsung Galaxy SII (Android 2.3.4)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.