Should yield more time to other apps when not busy

VERIFIED FIXED in mozilla0.9.1

Status

()

Core
Event Handling
P3
normal
VERIFIED FIXED
17 years ago
17 years ago

People

(Reporter: Simon Fraser, Assigned: Simon Fraser)

Tracking

Trunk
mozilla0.9.1
PowerPC
Mac System 8.5
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: needs sr=)

Attachments

(3 attachments)

(Assignee)

Description

17 years ago
We currently only call WaitNextEvent every 4 ticks, to optimize performance. 
However, we should only do this when not busy, otherwise we suck CPU time when we 
need not. This would be especially noticable on X.
(Assignee)

Comment 1

17 years ago
Created attachment 26221 [details] [diff] [review]
nsMacMessagePump.cpp fix
(Assignee)

Comment 2

17 years ago
Created attachment 26222 [details] [diff] [review]
nsToolkit.cpp/h changes to cache the event queue service etc.
(Assignee)

Comment 3

17 years ago
The second set of diffs remove a call to do_GetService by caching the 
nsIEventQueueService, and check to see if any events are available in a queue 
before calling ProcessPendingEvents. This should reduce the overhead of polling 
for PLEvents every time a little.
(Assignee)

Comment 4

17 years ago
Milestone. This needs more investigation on X.
Target Milestone: --- → mozilla0.9
(Assignee)

Comment 5

17 years ago
r/sr anyone?

Comment 7

17 years ago
P3
Priority: -- → P3

Updated

17 years ago
Whiteboard: needs sr=
(Assignee)

Comment 8

17 years ago
->0.9.1
Target Milestone: mozilla0.9 → mozilla0.9.1
(Assignee)

Comment 9

17 years ago
sr please waterson?

Comment 10

17 years ago
Oh sure, why not! sr=waterson
(Assignee)

Comment 11

17 years ago
This needs 76075 to be fixed to work properly.
Depends on: 76075
(Assignee)

Comment 12

17 years ago
Created attachment 30921 [details] [diff] [review]
Latest patch, adds some nsToolkit smarts to query event queue activity
(Assignee)

Comment 13

17 years ago
Fixes checked in.
(Assignee)

Comment 14

17 years ago
Checked in on 4 May
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 15

17 years ago
QA contact updated
QA Contact: gerardok → madhur

Comment 16

17 years ago
marking verified as per developers comments
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.