702450 - Admin accounts cause tracebacks on login

Status: VERIFIED WORKSFORME

(Firefox Affiliates Graveyard :: affiliates.mozilla.org, defect)

Description

[Matt Brandt [:mbrandt]]

Traceback (most recent call last):

 File "/data/www/affiliates.allizom.org/affiliates-app/vendor/src/django/django/core/handlers/base.py", line 111, in get_response
   response = callback(request, *callback_args, **callback_kwargs)

 File "/data/www/affiliates.allizom.org/affiliates-app/apps/shared/decorators.py", line 11, in decorator
   return view_func(request, *args, **kwargs)

 File "/data/www/affiliates.allizom.org/affiliates-app/apps/badges/views.py", line 54, in new_badge_step1
   user_locale = request.user.userprofile.locale

 File "/data/www/affiliates.allizom.org/affiliates-app/vendor/src/django/django/db/models/fields/related.py", line 239, in __get__
   rel_obj = self.related.model._base_manager.using(db).get(**params)

 File "/data/www/affiliates.allizom.org/affiliates-app/vendor/src/django/django/db/models/query.py", line 349, in get
   % self.model._meta.object_name)

DoesNotExist: UserProfile matching query does not exist.

Comment 1

[Matt Brandt [:mbrandt]]

It appears that this is the account that is linked to this 500 --> [e-mail]

Comment 2

[Osmose [:osmose, :mkelly]]

The root cause of this is that admin accounts, which we create using the `manage.py createsuperuser` command, do not have UserProfiles because they are not created via the registration form.

A possible solution would be to disallow logins from admin users. That way, if a legitimate user gets this error, we will know that a real error has occurred (as opposed to catching all errors caused by this and suppressing).

Either way, this isn't a blocker for the release and I'm moving it out of the 11/30 launch.

Comment 3

[Osmose [:osmose, :mkelly]]

I don't know when, but this was fixed a while ago. I've been able to stay logged in as an admin user on all environments for a long time.

Comment 4

[Matt Brandt [:mbrandt]]

Excellent - QA verified per comment 3