Change the names of nsSVGPathElement::GetScale and nsSVGTextPathFrame::GetPathScale

RESOLVED FIXED in mozilla11

Status

()

Core
SVG
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

Trunk
mozilla11
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 574472 [details] [diff] [review]
patch

The method names nsSVGPathElement::GetScale and nsSVGTextPathFrame::GetPathScale (especially the former) are less than helpful. Here's a patch to give them better names and add some documenting comments.
Attachment #574472 - Flags: review?(longsonr)

Updated

6 years ago
Attachment #574472 - Flags: review?(longsonr) → review+
(Assignee)

Comment 1

6 years ago
Pushed https://hg.mozilla.org/integration/mozilla-inbound/rev/44759e317dc8

Comment 2

6 years ago
https://hg.mozilla.org/mozilla-central/rev/44759e317dc8

To save time/mistakes when merging, please could you set assignee + target milestone when landing on inbound (https://wiki.mozilla.org/Tree_Rules/Inbound#Please_do_the_following_after_pushing_to_inbound).

Thanks :-)
Assignee: nobody → jwatt
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
(Assignee)

Comment 3

6 years ago
Oops, will do, thanks.
You need to log in before you can comment on or make changes to this bug.