702484 - Get rid of RestoreFocusAfterHdrButton function

Status: RESOLVED FIXED

(Thunderbird :: Message Reader UI, enhancement)

Description

[Jim Porter (:squib)]

I was passing through the code for the message header buttons, and I realized that RestoreFocusAfterHdrButton is no longer relevant, since the message header buttons don't take focus anymore. We should just remove this function, and possibly update the buttons to use command controllers too.

Comment 1

[:aceman]

The function is still called from many places. You say it is not relevant. So it does nothing useful and can just be removed?

Comment 2

[Jim Porter (:squib)]

It used to be needed when message header buttons were <xul:button> elements because those took focus. <xul:toolbarbutton>s don't, so the function doesn't do anything useful anymore.

Comment 3

[samueljselvarajah]

Hi, was wondering if this bug has been fixed or not? if not, i'd like to work on it?

Sam

Comment 4

[:aceman]

The function still exists, so you can work on it, thanks.
https://searchfox.org/comm-central/search?q=RestoreFocusAfterHdrButton

Comment 5

[samueljselvarajah]

I was required to complete a bug for a course, I have already worked on a bug so if anyone else wants to work on it im fine with that

Sam

Comment 6

[Vishal Das [:kindavishal]]

Hey folks,

I am looking to work on my first bug, I am good with Js, if anyone could guide me what's required here, I would like to work on this.

Best,
Vishal

Comment 7

[Elizabeth Mitchell]

Attachment: Bug 702484 - Remove RestoreFocusAfterHdrButton function. r=aleca

Comment 8

[Elizabeth Mitchell]

There's some related JavaScript event.stopPropogation(); that we can look at in the future and see if it can also be removed.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ae907514691b
Remove RestoreFocusAfterHdrButton function. r=aleca