PR_TRUE/PR_FALSE added as a result of bug 666446

RESOLVED FIXED in mozilla11

Status

()

Core
ImageLib
P5
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jwir3, Assigned: jwir3)

Tracking

Trunk
mozilla11
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
There were a couple of PR_TRUE/PR_FALSE literals added as a result of bug 666446 landing. These should be removed.
Version: unspecified → Trunk
(Assignee)

Comment 1

5 years ago
Created attachment 574500 [details] [diff] [review]
b702503 (v1)
Attachment #574500 - Flags: review?(dholbert)
Is there a way to prevent repeating it in the future?
(Assignee)

Comment 3

5 years ago
(In reply to Masatoshi Kimura [:emk] from comment #2)
> Is there a way to prevent repeating it in the future?

Well, we could remove the #defines, but I think we need them for some files, namely C files. I suppose we could make tbpl go orange if you add patches with PRBool (or even deny the push).

But, I think it's probably pretty minor, so I don't know if it's worth worrying about.
Attachment #574500 - Flags: review?(dholbert) → review+
(Assignee)

Comment 4

5 years ago
Pushed to inbound:

https://hg.mozilla.org/integration/mozilla-inbound/rev/4829dd3ae900
Whiteboard: [inbound]
(Assignee)

Updated

5 years ago
Whiteboard: [inbound]
(Assignee)

Updated

5 years ago
Target Milestone: --- → mozilla11

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/4829dd3ae900
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.