Closed
Bug 702503
Opened 13 years ago
Closed 13 years ago
PR_TRUE/PR_FALSE added as a result of bug 666446
Categories
(Core :: Graphics: ImageLib, defect, P5)
Core
Graphics: ImageLib
Tracking
()
RESOLVED
FIXED
mozilla11
People
(Reporter: jwir3, Assigned: jwir3)
Details
Attachments
(1 file)
2.53 KB,
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
There were a couple of PR_TRUE/PR_FALSE literals added as a result of bug 666446 landing. These should be removed.
Updated•13 years ago
|
Version: unspecified → Trunk
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #574500 -
Flags: review?(dholbert)
Comment 2•13 years ago
|
||
Is there a way to prevent repeating it in the future?
Assignee | ||
Comment 3•13 years ago
|
||
(In reply to Masatoshi Kimura [:emk] from comment #2) > Is there a way to prevent repeating it in the future? Well, we could remove the #defines, but I think we need them for some files, namely C files. I suppose we could make tbpl go orange if you add patches with PRBool (or even deny the push). But, I think it's probably pretty minor, so I don't know if it's worth worrying about.
Updated•13 years ago
|
Attachment #574500 -
Flags: review?(dholbert) → review+
Assignee | ||
Comment 4•13 years ago
|
||
Pushed to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/4829dd3ae900
Whiteboard: [inbound]
Assignee | ||
Updated•13 years ago
|
Whiteboard: [inbound]
Assignee | ||
Updated•13 years ago
|
Target Milestone: --- → mozilla11
Comment 5•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4829dd3ae900
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•