Closed Bug 702503 Opened 8 years ago Closed 8 years ago

PR_TRUE/PR_FALSE added as a result of bug 666446

Categories

(Core :: ImageLib, defect, P5)

defect

Tracking

()

RESOLVED FIXED
mozilla11

People

(Reporter: jwir3, Assigned: jwir3)

Details

Attachments

(1 file)

There were a couple of PR_TRUE/PR_FALSE literals added as a result of bug 666446 landing. These should be removed.
Version: unspecified → Trunk
Attached patch b702503 (v1)Splinter Review
Attachment #574500 - Flags: review?(dholbert)
Is there a way to prevent repeating it in the future?
(In reply to Masatoshi Kimura [:emk] from comment #2)
> Is there a way to prevent repeating it in the future?

Well, we could remove the #defines, but I think we need them for some files, namely C files. I suppose we could make tbpl go orange if you add patches with PRBool (or even deny the push).

But, I think it's probably pretty minor, so I don't know if it's worth worrying about.
Attachment #574500 - Flags: review?(dholbert) → review+
Pushed to inbound:

https://hg.mozilla.org/integration/mozilla-inbound/rev/4829dd3ae900
Whiteboard: [inbound]
Whiteboard: [inbound]
Target Milestone: --- → mozilla11
https://hg.mozilla.org/mozilla-central/rev/4829dd3ae900
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.