IAccessible::get_accName should return S_FALSE when there's no accessible name

RESOLVED FIXED in mozilla11

Status

()

Core
Disability Access APIs
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: surkov, Unassigned)

Tracking

(Blocks: 1 bug, {access})

unspecified
mozilla11
access
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Created attachment 574543 [details] [diff] [review]
patch
Attachment #574543 - Flags: review?(bolterbugz)
(Reporter)

Updated

6 years ago
Blocks: 459353
(Reporter)

Updated

6 years ago
In general I think I prefer

// some comment
// blah blah blah
// and more comment
if (x)
  return y;

to

if (x) {
  // a comment
  / more coment
  // blah blah blah
  return x;
}
other wise this seems fine to me if its what the docs say we should do (I haven't looked)
(Reporter)

Comment 2

6 years ago
Ok, done, the comment before if:

// The name was not provided, e.g. no alt attribute for an image. A screen
// reader may choose to invent its own accessible name, e.g. from an image src
// attribute. Refer to NS_OK_EMPTY_NAME return value.
(Reporter)

Comment 3

6 years ago
(In reply to Trevor Saunders (:tbsaunde) from comment #1)

> other wise this seems fine to me if its what the docs say we should do (I
> haven't looked)

that's per spec, see URL: http://msdn.microsoft.com/en-us/library/windows/desktop/dd318483%28v=VS.85%29.aspx

As Jamie noticed that was for years but we get asked about discrepancy between browser implementations. This return value shouldn't harm anybody and it appears to be correct.
Comment on attachment 574543 [details] [diff] [review]
patch

Yup looks good!
Comment on attachment 574543 [details] [diff] [review]
patch

r=me. I'd have a preference for only changing the return value and the last line of the comment (and otherwise preserving blame) - but I wouldn't block on it.
Attachment #574543 - Flags: review?(bolterbugz) → review+
(Reporter)

Comment 6

6 years ago
(In reply to David Bolter [:davidb] from comment #5)
> Comment on attachment 574543 [details] [diff] [review] [diff] [details] [review]
> patch
> 
> r=me. I'd have a preference for only changing the return value and the last
> line of the comment (and otherwise preserving blame) - but I wouldn't block
> on it.

small clean up while I'm about this code ;)
(Reporter)

Comment 7

6 years ago
inbound land https://hg.mozilla.org/integration/mozilla-inbound/rev/e7d5dd9efeca
https://hg.mozilla.org/mozilla-central/rev/e7d5dd9efeca
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in before you can comment on or make changes to this bug.