702528 - IAccessible::get_accName should return S_FALSE when there's no accessible name

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 1

[Trevor Saunders (:tbsaunde)]

In general I think I prefer

// some comment
// blah blah blah
// and more comment
if (x)
  return y;

to

if (x) {
  // a comment
  / more coment
  // blah blah blah
  return x;
}
other wise this seems fine to me if its what the docs say we should do (I haven't looked)

Comment 2

[alexander :surkov (:asurkov)]

Ok, done, the comment before if:

// The name was not provided, e.g. no alt attribute for an image. A screen
// reader may choose to invent its own accessible name, e.g. from an image src
// attribute. Refer to NS_OK_EMPTY_NAME return value.

Comment 3

[alexander :surkov (:asurkov)]

(In reply to Trevor Saunders (:tbsaunde) from comment #1)

> other wise this seems fine to me if its what the docs say we should do (I
> haven't looked)

that's per spec, see URL: http://msdn.microsoft.com/en-us/library/windows/desktop/dd318483%28v=VS.85%29.aspx

As Jamie noticed that was for years but we get asked about discrepancy between browser implementations. This return value shouldn't harm anybody and it appears to be correct.

Comment 4

[Marco Zehe (:MarcoZ)]

Comment on attachment 574543 [details] [diff] [review]
patch

Yup looks good!

Comment 5

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 574543 [details] [diff] [review]
patch

r=me. I'd have a preference for only changing the return value and the last line of the comment (and otherwise preserving blame) - but I wouldn't block on it.

Comment 6

[alexander :surkov (:asurkov)]

(In reply to David Bolter [:davidb] from comment #5)
> Comment on attachment 574543 [details] [diff] [review] [diff] [details] [review]
> patch
> 
> r=me. I'd have a preference for only changing the return value and the last
> line of the comment (and otherwise preserving blame) - but I wouldn't block
> on it.

small clean up while I'm about this code ;)

Comment 7

[alexander :surkov (:asurkov)]

inbound land https://hg.mozilla.org/integration/mozilla-inbound/rev/e7d5dd9efeca

Comment 8

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/e7d5dd9efeca