From the 3 files that are marked for preprocessing in browser/devtools/jar.mn, only scratchpad.xul looks like it needs it and that one could probably do without the #ifdef 0 to hide a comment block: * content/browser/inspector.html (highlighter/inspector.html) * content/browser/scratchpad.xul (scratchpad/scratchpad.xul) * content/browser/scratchpad.js (scratchpad/scratchpad.js) Hopefully this would shorten build times by a tiny fraction, which might be non-trivial for tinderboxes.
Created attachment 596480 [details] [diff] [review] patch v1 Let's do it ;) More importantly it avoids surprises when using --enable-chrome-format=symlink.
I remember I had problems when I filed the bug getting a functional build after clobbering. Does this patch work after building from a clean slate? A try run should be sufficient, too.
Comment on attachment 596480 [details] [diff] [review] patch v1 Unassigned review! Sending to... *spins wheel* dcamp! Please review/reassign/close as appropriate.
Comment on attachment 596480 [details] [diff] [review] patch v1 I dunno. Including that comment in our source file could really bloat the Firefox download size. R+ anyway.
(totally stole that review from dcamp. swish.)
Is this ready to land? Does it need rebasing?
Created attachment 628288 [details] [diff] [review] Patch v2 Updated patch to reflect current reality. Try run: https://tbpl.mozilla.org/?tree=Try&rev=92e3ddd476b9
5 years ago