The default bug view has changed. See this FAQ.

Unnecessary preprocessing in the devtools jar manifest

RESOLVED FIXED in Firefox 15

Status

()

Firefox
Developer Tools
--
enhancement
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: past, Assigned: cedricv)

Tracking

Trunk
Firefox 15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 attachment, 1 obsolete attachment)

From the 3 files that are marked for preprocessing in browser/devtools/jar.mn, only scratchpad.xul looks like it needs it and that one could probably do without the #ifdef 0 to hide a comment block:

*   content/browser/inspector.html                (highlighter/inspector.html)
*   content/browser/scratchpad.xul                (scratchpad/scratchpad.xul)
*   content/browser/scratchpad.js                 (scratchpad/scratchpad.js)

Hopefully this would shorten build times by a tiny fraction, which might be non-trivial for tinderboxes.
(Assignee)

Comment 1

5 years ago
Created attachment 596480 [details] [diff] [review]
patch v1

Let's do it ;)
More importantly it avoids surprises when using --enable-chrome-format=symlink.
Assignee: nobody → cedricv
Status: NEW → ASSIGNED
Attachment #596480 - Flags: review?
I remember I had problems when I filed the bug getting a functional build after clobbering. Does this patch work after building from a clean slate? A try run should be sufficient, too.
Comment on attachment 596480 [details] [diff] [review]
patch v1

Unassigned review! Sending to... *spins wheel* dcamp!

Please review/reassign/close as appropriate.
Attachment #596480 - Flags: review? → review?(dcamp)
Comment on attachment 596480 [details] [diff] [review]
patch v1

I dunno. Including that comment in our source file could really bloat the Firefox download size. R+ anyway.
Attachment #596480 - Flags: review?(dcamp) → review+
(totally stole that review from dcamp. swish.)

Comment 6

5 years ago
Is this ready to land?  Does it need rebasing?
Created attachment 628288 [details] [diff] [review]
Patch v2

Updated patch to reflect current reality. Try run:
https://tbpl.mozilla.org/?tree=Try&rev=92e3ddd476b9
Attachment #596480 - Attachment is obsolete: true
Whiteboard: [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/e7f1d04c8ab1
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/e7f1d04c8ab1
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 15
You need to log in before you can comment on or make changes to this bug.