copy over JSON doc annotations from FR mainline

ASSIGNED
Assigned to

Status

Tamarin
Documentation
ASSIGNED
6 years ago
6 years ago

People

(Reporter: pnkfelix, Assigned: Brent Baker)

Tracking

(Blocks: 1 bug)

Details

(Whiteboard: integration-pain-point)

There are documentation comments in JSON.as that should be propagated over to tamarin-redux.

This is a work item that will ease integrations from TR/TR-sec to FRmain.

(Don't let this block integrations unless you cannot stand to have diff's outstanding between FRmain and TR-sec.  As in: I'm not going to let it block integration right now.)
(Reporter)

Updated

6 years ago
Assignee: nobody → fklockii
(Reporter)

Updated

6 years ago
Blocks: 710177
(Reporter)

Updated

6 years ago
Whiteboard: integration-pain-point
not gonna spend time on this right now
Assignee: fklockii → nobody
(Assignee)

Comment 2

6 years ago
I think this is pretty much done, minus a single blank line inserted into one of the API documentation blocks.
Assignee: nobody → brbaker
Status: NEW → ASSIGNED
(Assignee)

Comment 3

6 years ago
The majority of this bug was taken care of in CL@1036353, again the only diff at the moment between Mainline and tamarin is a single blank line in documentation block for the stringify() API.


==== //depot/main/FlashRuntime/Main/code/third_party/avmplus/core/JSON.as#10 (text) - //depot/users/FlashRuntime/avm/code/third_party/avmplus/core/JSON.as#4 (text) ==== content
@@ -202,6 +202,7 @@
         * is a non-negative number <i>x</i>, then the gap is <i>x</i> space characters, to a maximum of ten spaces.
         * When the argument passed to the <code>space</code> parameter is not a String a Number, it is converted to a
         * String for use as the gap in the output. Execution then proceeds.</p>
+        *
         * <p>When the <code>stringify()</code> method encounters a cyclic structure, it throws a TypeError with error ID <code>kJSONCyclicStructure</code>. It also posts a localized error message.</p>
 
         * @param value The ActionScript value to be converted into a JSON string
You need to log in before you can comment on or make changes to this bug.