debug method PrintImageDecoders() in imgLoader should be removed (Doesn't work and is confusing)

RESOLVED FIXED in mozilla17

Status

()

Core
ImageLib
--
trivial
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: fowl, Unassigned)

Tracking

Trunk
mozilla17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0a1) Gecko/20111114 Firefox/11.0a1
Build ID: 20111114031820

Steps to reproduce:

http://hg.mozilla.org/mozilla-central/file/9ae1d4f44b8b/image/src/imgLoader.cpp#l108

While playing around with writing a toy image decoder (in js) this code kept showing up in searches and confusing me.  It's been horribly broken since bug 513681 and it's been there since pre-hg.
(Reporter)

Updated

6 years ago
Severity: normal → trivial
Component: General → ImageLib
OS: Windows 7 → All
Hardware: x86_64 → All
(Reporter)

Comment 1

5 years ago
Created attachment 654600 [details] [diff] [review]
Remove confusing dead code implying that image decoders are pluggable.

This is trivial really, but I did build and run it on my machine anyway. 

I used getReviewer.py to find a reviewer, so if it's not you apologies but I'm just following the instructions :P
Attachment #654600 - Flags: review?(justin.lebar+bug)
> I used getReviewer.py to find a reviewer, so if it's not you apologies but I'm just 
> following the instructions :P

I'm a fine reviewer for this code.  But also, choosing a poor reviewer is not a faux pas; the reviewer should redirect your request towards someone else without complaint.  :)

Thanks for the patch!
Attachment #654600 - Flags: review?(justin.lebar+bug) → review+
Normally we'd ask for a patch formatted for checkin-needed [1] before pushing, but since this is your first one, I've added that info and pushed:

  https://hg.mozilla.org/integration/mozilla-inbound/rev/16e1ff49a6a5

Thanks again for the patch!

[1] http://blog.bonardo.net/2010/06/22/so-youre-about-to-use-checkin-needed
https://hg.mozilla.org/mozilla-central/rev/16e1ff49a6a5
Status: UNCONFIRMED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.